8000 minify error with uglifyjs · Issue #218 · lodash/lodash · GitHub
[go: up one dir, main page]
Skip to content

minify error with uglifyjs #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gmoulin opened this issue Mar 26, 2013 · 8 comments
Closed

minify error with uglifyjs #218

gmoulin opened this issue Mar 26, 2013 · 8 comments
Labels
bug

Comments

@gmoulin
Copy link
gmoulin commented Mar 26, 2013

Hello, I get this error while trying to compile a csp minified build.

Lodash version 1.1.0

I use :

sudo lodash csp -m

Compressing lodash.custom.min using UglifyJS...
Error: Cannot find module '/usr/lib/node_modules/lodash/vendor/uglifyjs/tools/node.js'
at Function.Module._resolveFilename (module.js:338:15)
at Function.Module._load (module.js:280:25)
at Module.require (module.js:364:17)
at require (module.js:380:17)
at Minify.uglify (/usr/lib/node_modules/lodash/build/minify.js:448:22)
at Minify.onClosureAdvancedGzip (/usr/lib/node_modules/lodash/build/minify.js:573:14)
at Gzip.onEnd (zlib.js:166:5)
at Gzip.EventEmitter.emit (events.js:117:20)
at _stream_readable.js:872:14
at process._tickCallback (node.js:415:13)

In /usr/lib/node_modules/lodash/vendor/uglifyjs/ I only have an empty lib folder and a LICENSE file.
I tried to delete the uglifyjs folder, same result.
I reinstalled lodash, same result.
@jdalton
Copy link
Member
jdalton commented Mar 26, 2013

@kitcambridge is on the case!

@ghost
Copy link
ghost commented Mar 26, 2013

It looks like the gzip decompression succeeds, but tar.Extract doesn't actually handle the piped stream. Node v0.10 implemented "Streams2," but they're backward-compatible (at least our usage is; there's one edge case that doesn't apply to us). The fact that you're experiencing this issue with v0.8 is puzzling, too.

@jdalton
Copy link
Member
jdalton commented Mar 26, 2013

@kitcambridge Can you sanity check me. Node 0.8.20 is here and then install npm install -g lodash@1.0.1 (uninstall previous ones) and then do something like sudo lodash.

@ghost
Copy link
ghost commented Mar 26, 2013

@jdalton Hmm, both Closure Compiler and UglifyJS downloaded successfully for me on v0.8.20—and I was able to create a minified custom build.

@jdalton
Copy link
Member
jdalton commented Mar 26, 2013

Ah, yap, I checked back and it did eventually download. So back to thinking it's a Node 0.10.0 thing.

@gmoulin
Copy link
Author
gmoulin commented Mar 27, 2013

I retried this morning, same problem.
Manually downloading uglifyjs with the provided command worked.

@jdalton
Copy link
Member
jdalton commented Mar 27, 2013

I haven't bumped yet. It's fixed on edge.
ACB2

jdalton added a commit that referenced this issue Aug 29, 2013
@jdalton
Update vendor/tar for Node v0.10.0+. [closes #218]
73d9a28 
Former-commit-id: 9b35d27127dbd85dd56808e50bf255bbd3413c62
jdalton added a commit that referenced this issue Sep 1, 2013
@jdalton
Update vendor/tar for Node v0.10.0+. [closes #218]
736919e 
Former-commit-id: 9b35d27127dbd85dd56808e50bf255bbd3413c62
jdalton added a commit that referenced this issue Sep 25, 2014
@jdalton
Update vendor/tar for Node v0.10.0+. [closes #218]
2c7cc2c 
Former-commit-id: 9b35d27127dbd85dd56808e50bf255bbd3413c62
@lock
Copy link
lock bot commented Jan 21, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdalton @gmoulin
0