8000 remove deprecated HttpRequest type alias by alexrashed · Pull Request #9757 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

remove deprecated HttpRequest type alias #9757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 8, 2024
Merged

remove deprecated HttpRequest type alias #9757

merged 1 commit into from
Jun 8, 2024

Conversation

alexrashed
Copy link
Member
@alexrashed alexrashed commented Nov 28, 2023 •
edited
Loading

Motivation

This PR contains a very small cleanup which removes localstack.aws.api.core.HttpRequest and localstack.aws.api.core.HttpResponse, which are deprecated type aliases for localstack.http.Request and localstack.http.Response.

Changes

  • Changes the usages of localstack.aws.api.core.[HttpRequest|HttpResponse] to use localstack.http.[Request|Response] everywhere.

Testing

  • I have verified that these deprecated type aliases are not used on our proprietary code anywhere. If the tests are 💚, this should not have any implications here.
  • However, there is a dependency on HttpRequest in auth_proxy.py in the AWS Replicator Extension.
    • This is the only usage of HttpRequest or HttpResponse (at the time of writing this) in any other repo of the organization on GitHub.

TODO

@alexrashed alexrashed added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Nov 28, 2023
@alexrashed alexrashed added this to the 3.1 milestone Nov 28, 2023
@alexrashed alexrashed self-assigned this Nov 28, 2023
@alexrashed alexrashed mentioned this pull request Nov 28, 2023
Open
@coveralls
Copy link

Coverage Status

coverage: 84.134% (+0.008%) from 84.126%
when pulling aa80600 on remove-deprecated-http-request
into 82fd17a on master.

@github-actions GitHub Actions
Copy link
github-actions bot commented Nov 28, 2023 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 35m 13s ⏱️ - 1m 20s
3 028 tests ±0  2 693 ✅ ±0  335 💤 ±0  0 ❌ ±0 
3 030 runs  ±0  2 693 ✅ ±0  337 💤 ±0  0 ❌ ±0 

Results for commit 3b6207e. ± Comparison against base commit 88d1ba9.

♻️ This comment has been updated with latest results.

@alexrashed alexrashed modified the milestones: 3.1, 3.2 Jan 24, 2024
@alexrashed alexrashed modified the milestones: 3.2, 3.3 Feb 27, 2024
@alexrashed alexrashed modified the milestones: 3.3, 3.4 Mar 19, 2024
@alexrashed alexrashed modified the milestones: 3.4, Playground Apr 24, 2024
@alexrashed alexrashed mentioned this pull request Jun 7, 2024
Merged
@alexrashed alexrashed force-pushed the remove-deprecated-http-request branch from aa80600 to 717ed01 Compare June 7, 2024 12:14
@alexrashed alexrashed force-pushed the remove-deprecated-http-request branch from 717ed01 to 3b6207e Compare June 7, 2024 12:20
@github-actions GitHub Actions
Copy link
github-actions bot commented Jun 7, 2024

S3 Image Test Results (AMD64 / ARM64)

  2 files  ±0    2 suites  ±0   3m 7s ⏱️ +2s
404 tests ±0  352 ✅ ±0   52 💤 ±0  0 ❌ ±0 
808 runs  ±0  704 ✅ ±0  104 💤 ±0  0 ❌ ±0 

Results for commit 3b6207e. ± Comparison against base commit 88d1ba9.

@alexrashed alexrashed marked this pull request as ready for review June 7, 2024 12:41
thrau
thrau approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member
@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup! ✨

@alexrashed alexrashed merged commit 3021997 into master Jun 8, 2024
37 checks passed
@alexrashed alexrashed deleted the remove-deprecated-http-request branch June 8, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thrau thrau thrau approved these changes

@joe4dev joe4dev Awaiting requested review from joe4dev joe4dev is a code owner

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

@dfangl dfangl Awaiting requested review from dfangl dfangl is a code owner

Assignees

@alexrashed alexrashed

Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
Playground
Development

Successfully merging this pull request may close these issues.
3 participants
@alexrashed @coveralls @thrau
0