8000 remove remaining (transitive) usages of Quart by alexrashed · Pull Request #9754 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

remove remaining (transitive) usages of Quart #9754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2024
Merged

remove remaining (transitive) usages of Quart #9754

merged 1 commit into from
Jun 6, 2024

Conversation

alexrashed
Copy link
Member
@alexrashed alexrashed commented Nov 28, 2023 •
edited
Loading

Motivation

During the review of #9712, it was made explicit that we still have a dependency on Quart (even though we switched to the underlying hypercorn as ASGI server quite a while back).

This PR removes the last remaining references to Quart and removes the dependency from the setup.cfg.

Changes

  • Removes all remaining references to Quart.
  • Migrates some tests using Quart as a mock server to use the httpserver fixture.
  • Remove the old function providing a Quart server (which was only used in tests lately).
  • Cleanup and make the HTTP server patching explicit (even though it's still not too obvious, but now it's at least explicitly called instead of implicitly when loading the module somewhere).

Testing

TODO

@alexrashed alexrashed added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Nov 28, 2023
@alexrashed alexrashed added this to the 3.1 milestone Nov 28, 2023
@alexrashed alexrashed self-assigned this Nov 28, 2023
@alexrashed alexrashed requested a review from thrau as a code owner November 28, 2023 12:38
@alexrashed alexrashed mentioned this pull request Nov 28, 2023
Merged
2 tasks
@github-actions GitHub Actions
Copy link
github-actions bot commented Nov 28, 2023 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 39m 55s ⏱️ + 1m 24s
3 015 tests ±0  2 692 ✅ ±0  323 💤 ±0  0 ❌ ±0 
3 017 runs  ±0  2 692 ✅ ±0  325 💤 ±0  0 ❌ ±0 

Results for commit 99c208c. ± Comparison against base commit b3a7651.

♻️ This comment has been updated with latest results.

@alexrashed alexrashed changed the title remove remainig (transitive) usages of Quart remove remaining (transitive) usages of Quart Nov 28, 2023
@alexrashed alexrashed marked this pull request as draft November 28, 2023 14:42
@alexrashed alexrashed mentioned this pull request Nov 28, 2023
Open
@alexrashed alexrashed modified the milestones: 3.1, 3.2 Jan 24, 2024
@alexrashed alexrashed modified the milestones: 3.2, 3.3 Feb 27, 2024
@alexrashed alexrashed modified the milestones: 3.3, 3.4 Mar 19, 2024
@alexrashed alexrashed modified the milestones: 3.4, Playground Apr 24, 2024
@thrau thrau force-pushed the remove-usages-of-quart branch from b71c97c to 99c208c Compare June 5, 2024 22:25
@thrau thrau modified the milestones: Playground, 3.5 Jun 5, 2024
@thrau
Copy link
Member
thrau commented Jun 5, 2024

I rebased the PR, had to do a few changes, but should be good to go now! @alexrashed

@alexrashed alexrashed marked this pull request as ready for review June 6, 2024 06:53
@alexrashed
Copy link
Member Author

Thanks a lot, @thrau for moving the legacy code to the extension with localstack/localstack-extensions#64 and rebasing this PR! 🦸🏽
From my point of view it's looking good, however I can't review my own PR 😛
Happy for any reviews / approvals, afterwards - and after localstack/localstack-extensions#64 is merged - we can finally merge this! 🥳

thrau
thrau approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member
@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks so much for driving to clean this up! happy we're giving way to the modern frameworks we have 🥳

@alexrashed alexrashed merged commit 80c41ca into master Jun 6, 2024
32 checks passed
@alexrashed alexrashed dele 8A79 ted the remove-usages-of-quart branch June 6, 2024 10:13
@alexrashed alexrashed mentioned this pull request Jun 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thrau thrau thrau approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert

@whummer whummer Awaiting requested review from whummer

@bentsku bentsku Awaiting requested review from bentsku

Assignees

@alexrashed alexrashed

Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
3.5
Development

Successfully merging this pull request may close these issues.
2 participants
@alexrashed @thrau
0