8000 Remove legacy internal call detection helper by viren-nadkarni · Pull Request #9616 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

Remove legacy internal call detection helper #9616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2023
Merged

Remove legacy internal call detection helper #9616

merged 1 commit into from
Nov 14, 2023

Conversation

viren-nadkarni
Copy link
Member
@viren-nadkarni viren-nadkarni commented Nov 13, 2023 •
edited
Loading

Motivation

LocalStack now uses the RequestContext.is_internal_call attribute to indicate internal cross-service calls.

Implementation

This PR removes the use of legacy helper which relies on HEADER_LOCALSTACK_ACCOUNT_ID header which itself is a vestige of the old aws_stack.connect_to_service() utility.

The old client was removed in #9343, and this is not a breaking change.

@viren-nadkarni viren-nadkarni self-assigned this Nov 13, 2023
@viren-nadkarni viren-nadkarni added the semver: patch Non-breaking changes which can be included in patch releases label Nov 13, 2023
@coveralls
Copy link

Coverage Status

coverage: 84.006% (-0.003%) from 84.009%
when pulling e98b153 on remove-legacy-is-internal-call
into 78999d0 on master.

@viren-nadkarni viren-nadkarni marked this pull request as ready for review November 13, 2023 13:24
@github-actions GitHub Actions
Copy link

LocalStack Community integration with Pro

       2 files         2 suites   1h 14m 30s ⏱️
2 307 tests 2 009 ✔️ 298 💤 0 ❌
2 308 runs  2 009 ✔️ 299 💤 0 ❌

Results for commit e98b153.

alexrashed
alexrashed approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member
@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 🚀

@viren-nadkarni viren-nadkarni added this to the Playground milestone Nov 14, 2023
@viren-nadkarni viren-nadkarni merged commit e18c518 into master Nov 14, 2023
@viren-nadkarni viren-nadkarni deleted the remove-legacy-is-internal-call branch November 14, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexrashed alexrashed alexrashed approved these changes

@thrau thrau Awaiting requested review from thrau

Assignees

@viren-nadkarni viren-nadkarni

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
Playground
Development

Successfully merging this pull request may close these issues.
3 participants
@viren-nadkarni @coveralls @alexrashed
0