fix S3 pre-signed logic for IGNORED_SIGV4_HEADERS #9609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0f4221c to
e6aba66
Compare
bentsku
commented
Nov 14, 2023
Comment on lines
-69
to
-76
| ALLOWED_QUERY_PARAMS = [ | ||
| "x-id", | ||
| "x-amz-user-agent", | ||
| "x-amz-content-sha256", | ||
| "versionid", | ||
| "uploadid", | ||
| "partnumber", | ||
| ] |
Contributor
Author
There was a problem hiding this comment.
this was not used anywhere
steffyP
approved these changes
Nov 14, 2023
Member
There was a problem hiding this comment.
Great work, @bentsku! 🙇♀️ 🚀
Love that the test is even aws validated ❤️ and very smart test setup with the meta-events 😄
This is already a very specific case for S3, the new provider is truely amazing 🚀 👏
Just added a few NITs, but nothing blocking the merge!
9d278f4 to
5297618
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Following up on #9603, I've quickly investigated the issue for the pre-signed URL message showing a non valid signature for a very simple request and quickly found the issue related to signed headers being in the ignore list.
Changes
SignedHeaders, and only ignore if they're missing