8000 fix missing support for eventbridge notifications in legacy AWS::S3::Bucket by dominikschubert · Pull Request #9338 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

fix missing support for eventbridge notifications in legacy AWS::S3::Bucket #9338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2023
Merged

fix missing support for eventbridge notifications in legacy AWS::S3::Bucket #9338

merged 1 commit into from
Oct 12, 2023

Conversation

dominikschubert
Copy link
Member

Motivation

When writing the workshop sample we noticed that it didn't create the necessary event bridge notification configuration.

Changes

  • Adds support for EventBridgeConfiguration to legacy AWS::S3::Bucket resource provider

@dominikschubert dominikschubert self-assigned this Oct 12, 2023
@dominikschubert dominikschubert added the semver: patch Non-breaking changes which can be included in patch releases label Oct 12, 2023
steffyP
steffyP approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member
@steffyP steffyP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 thanks for providing the fix 🙏

@coveralls
Copy link

Coverage Status

coverage: 82.945% (+0.02%) from 82.929% when pulling 94be3e0 on add-cfn-s3-bucket-eventbridge-notifications into 48a09e9 on master.

@github-actions
Copy link

LocalStack Community integration with Pro

       2 files  ±0         2 suites  ±0   1h 9m 53s ⏱️ - 1m 35s
2 251 tests ±0  1 750 ✔️ ±0  501 💤 ±0  0 ❌ ±0 
2 252 runs  ±0  1 750 ✔️ ±0  502 💤 ±0  0 ❌ ±0 

Results for commit 94be3e0. ± Comparison against base commit 48a09e9.

@dominikschubert dominikschubert merged commit b569aa4 into master Oct 12, 2023
@dominikschubert dominikschubert deleted the add-cfn-s3-bucket-eventbridge-notifications branch October 12, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffyP steffyP steffyP approved these changes

@bentsku bentsku Awaiting requested review from bentsku

@macnev2013 macnev2013 Awaiting requested review from macnev2013

Assignees

@dominikschubert dominikschubert

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dominikschubert @coveralls @steffyP
0