8000 Use region-agnostic bucket create for Transcribe tests by viren-nadkarni · Pull Request #9318 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

Use region-agnostic bucket create for Transcribe tests #9318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2023
Merged

Use region-agnostic bucket create for Transcribe tests #9318

merged 1 commit into from
Oct 10, 2023

Conversation

viren-nadkarni
Copy link
Member

Motivation

This PR fixes test execution error when a non-default TEST_AWS_REGION_NAME is used.

This happens because S3 CreateBucket requires LocationConstraint information when any region other than us-east-1 is used. Our s3_create_bucket fixture takes care of such situations.

Implementation

Just use the s3_create_bucket fixture to create the S3 bucket instead of the direct S3 CreateBucket.

@viren-nadkarni viren-nadkarni added the semver: patch Non-breaking changes which can be included in patch releases label Oct 9, 2023
@coveralls
Copy link

Coverage Status

coverage: 82.971% (+0.07%) from 82.899% when pulling 87ea5c7 on transcribe-tests-xaccount into 7fc2ccc on master.

@github-actions
Copy link
github-actions bot commented Oct 9, 2023

LocalStack Community integration with Pro

       2 files         2 suites   1h 10m 6s ⏱️
2 243 tests 1 741 ✔️ 502 💤 0 ❌
2 244 runs  1 741 ✔️ 503 💤 0 ❌

Results for commit 87ea5c7.

ackdav
ackdav approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member
@ackdav ackdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 makes sense! thx!

@viren-nadkarni viren-nadkarni merged commit b2a63ac into master Oct 10, 2023
@viren-nadkarni viren-nadkarni deleted the transcribe-tests-xaccount branch October 10, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ackdav ackdav ackdav approved these changes

@sannya-singal sannya-singal Awaiting requested review from sannya-singal sannya-singal is a code owner

Assignees
No one assigned
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@viren-nadkarni @coveralls @ackdav
0