8000 Disable AWS::ECR::Repository mock resource provider by dominikschubert · Pull Request #9315 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

Disable AWS::ECR::Repository mock resource provider #9315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2023
Merged

Disable AWS::ECR::Repository mock resource provider #9315

merged 1 commit into from
Oct 9, 2023

Conversation

dominikschubert
Copy link
Member

Motivation

The current code isn't set up to handle this case where -ext overwrites a resource provider, especially with the -ext provider being a GenericBaseModel. We'll handle this later but for now we should unblock the pipeline again.

Changes

  • Disables the activation of the AWS::ECR::Repository resource provider, which should unblock -ext

@dominiksch 8000 ubert dominikschubert self-assigned this Oct 9, 2023
@dominikschubert dominikschubert added the semver: patch Non-breaking changes which can be included in patch releases label Oct 9, 2023
alexrashed
alexrashed approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member
@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping on this to make sure the pipeline is unblocked again! 💯

@coveralls
Copy link

Coverage Status

coverage: 82.95% (-0.07%) from 83.023% when pulling d460369 on disable_mock_ecr_repo-provider into b6b7f0f on master.

@github-actions
Copy link
github-actions bot commented Oct 9, 2023

LocalStack Community integration with Pro

       2 files         2 suites   1h 13m 40s ⏱️
2 243 tests 1 741 ✔️ 502 💤 0 ❌
2 244 runs  1 741 ✔️ 503 💤 0 ❌

Results for commit d460369.

@dominikschubert dominikschubert merged commit 7fc2ccc into master Oct 9, 2023
@dominikschubert dominikschubert deleted the disable_mock_ecr_repo-provider branch October 9, 2023 09:03
@simonrw simonrw mentioned this pull request Oct 11, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonrw simonrw simonrw approved these changes

@alexrashed alexrashed alexrashed approved these changes

@pinzon pinzon Awaiting requested review from pinzon

Assignees

@dominikschubert dominikschubert

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dominikschubert @coveralls @simonrw @alexrashed
0