8000 Add support for fn::select in conditional by pinzon · Pull Request #9311 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

Add support for fn::select in conditional #9311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2023
Merged

Add support for fn::select in conditional #9311

merged 1 commit into from
Oct 9, 2023

Conversation

pinzon
Copy link
Member
@pinzon pinzon commented Oct 6, 2023 •
edited
Loading

Motivation

As shown in the issue #9300 CFn should be able to support using a !Select function in a Conditional.

Changes

The resolve_condition function now also supports a case for Fn::Select. According to the function documentation, the select can also resolve references.

Testing

Added a simplet AWS validated test to confirm the expected behaviour.

@pinzon pinzon added the semver: patch Non-breaking changes which can be included in patch releases label Oct 6, 2023
@coveralls
Copy link

Coverage Status

coverage: 83.007% (-0.03%) from 83.032% when pulling a547f26 on feat/cfn-select-in-conditional into e7ddddd on master.

@github-actions
Copy link
github-actions bot commented Oct 6, 2023

LocalStack Community integration with Pro

       2 files         2 suites   1h 13m 6s ⏱️
2 244 tests 1 742 ✔️ 502 💤 0 ❌
2 245 runs  1 742 ✔️ 503 💤 0 ❌

Results for commit a547f26.

dominikschubert
dominikschubert approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member
@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pinzon pinzon merged commit 6d2cc7c into master Oct 9, 2023
@alexrashed alexrashed deleted the feat/cfn-select-in-conditional branch November 28, 2023 13:05
@dominikschubert dominikschubert mentioned this pull request Nov 28, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikschubert dominikschubert dominikschubert approved these changes

@simonrw simonrw Awaiting requested review from simonrw simonrw is a code owner

Assignees
No one assigned
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pinzon @coveralls @dominikschubert
0