8000 Helper changes to support `eksctl` and CDK L2 EKS construct by simonrw · Pull Request #9309 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

Helper changes to support eksctl and CDK L2 EKS construct #9309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 17, 2023
Merged

Helper changes to support eksctl and CDK L2 EKS construct #9309

merged 4 commits into from
Oct 17, 2023

Conversation

simonrw
Copy link
Contributor
@simonrw simonrw commented Oct 6, 2023 •
edited
Loading

Motivation

We want to support eksctl in the -ext repo, but this requires some minor changes in utilities imported from community. Also there are some bugs that need fixing.

Changes

  • Enable AWS::EKS::NodeGroup resource provider
  • Fix logging bug in CFn
  • deploy_cfn_template deletes stacks in reverse order of creation
  • Add keys_to_upper function

TODO

  • delete nodegroup service method for proper cleanup
  • other nodegroup methods

@simonrw simonrw added the semver: patch Non-breaking changes which can be included in patch releases label Oct 6, 2023
@simonrw simonrw self-assigned this Oct 6, 2023
@coveralls
Copy link
coveralls commented Oct 6, 2023 •
edited
Loading

Coverage Status

coverage: 83.001% (+0.01%) from 82.987% when pulling 2992903 on eksctl-support into cc1efb8 on master.

@github-actions
Copy link
github-actions bot commented Oct 6, 2023 •
edited
Loading

LocalStack Community integration with Pro

       2 files  ±0         2 suites  ±0   1h 16m 34s ⏱️ - 3m 45s
2 254 tests ±0  1 753 ✔️ +1  501 💤 ±0  0 ❌  - 1 
2 255 runs  ±0  1 753 ✔️ +1  502 💤 ±0  0 ❌  - 1 

Results for commit 2992903. ± Comparison against base commit cc1efb8.

♻️ This comment has been updated with latest results.

@simonrw simonrw force-pushed the eksctl-support branch 2 times, most recently from 2b290f6 to dfd9e17 Compare October 11, 2023 07:57
@simonrw simonrw requested a review from dfangl October 12, 2023 13:47
@simonrw simonrw marked this pull request as ready for review October 13, 2023 09:35
@simonrw simonrw changed the title Helper changes to support eksctl Initial eksctl/EKS CDK support Oct 13, 2023
@simonrw simonrw changed the title Initial eksctl/EKS CDK support Helper changes to support eksctl and CDK L2 EKS construct Oct 13, 2023
dfangl
dfangl approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member
@dfangl dfangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@simonrw simonrw merged commit 6662d91 into master Oct 17, 2023
@simonrw simonrw deleted the eksctl-support branch October 17, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfangl dfangl dfangl approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert

@pinzon pinzon Awaiting requested review from pinzon

Assignees

@simonrw simonrw

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simonrw @coveralls @dfangl
0