8000 Add ElasticBeanstalk resources to list of resource providers by pinzon · Pull Request #9308 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

Add ElasticBeanstalk resources to list of resource providers #9308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 11, 2023
Merged

Add ElasticBeanstalk resources to list of resource providers #9308

merged 2 commits into from
Oct 11, 2023

Conversation

pinzon
Copy link
Member
@pinzon pinzon commented Oct 6, 2023

Motivation

This PR adds some new available resources to the list.

@pinzon pinzon added the semver: patch Non-breaking changes which can be included in patch releases label Oct 6, 2023
@coveralls
Copy link
coveralls commented Oct 6, 2023 •
edited
Loading

Coverage Status

coverage: 82.943% (-0.006%) from 82.949% when pulling 76dce3b on feat/elasticbeanstalk-cfn into c129376 on master.

@github-actions
Copy link
github-actions bot commented Oct 6, 2023 •
edited
Loading

LocalStack Community integration with Pro

       2 files         2 suites   1h 15m 51s ⏱️
2 251 tests 1 750 ✔️ 501 💤 0 ❌
2 252 runs  1 750 ✔️ 502 💤 0 ❌

Results for commit 76dce3b.

♻️ This comment has been updated with latest results.

simonrw
simonrw requested changes Oct 11, 2023
View reviewed changes
Copy link
Contributor
@simonrw simonrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make sure you rebase this before merging (see line comment)

localstack/services/cloudformation/resource_provider.py Outdated
"AWS::ElasticBeanstalk::Environment": "ResourceProvider",
"AWS::ElasticBeanstalk::ConfigurationTemplate": "ResourceProvider",
# "AWS::SSM::Parameter": "GenericBaseModel",
"AWS::ECR::Repository": "ResourceProvider",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to comment out this line, or rebase onto master since we have currently disabled cross-repo resources

@pinzon pinzon force-pushed the feat/elasticbeanstalk-cfn branch from 929f931 to 76dce3b Compare October 11, 2023 15:17
@pinzon pinzon requested a review from simonrw October 11, 2023 15:46
@pinzon pinzon merged commit 9c716a6 into master Oct 11, 2023
@alexrashed alexrashed deleted the feat/elasticbeanstalk-cfn branch November 28, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikschubert dominikschubert Awaiting requested review from dominikschubert

@simonrw simonrw Awaiting requested review from simonrw

Assignees
No one assigned
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pinzon @coveralls @simonrw
0