8000 Implemented AWS::KMS::* Resource provider for CloudFormation by Morijarti · Pull Request #9304 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

Implemented AWS::KMS::* Resource provider for CloudFormation #9304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 10, 2023
Merged

Implemented AWS::KMS::* Resource provider for CloudFormation #9304

merged 6 commits into from
Oct 10, 2023

Conversation

Morijarti
Copy link
Contributor

Changes

Implemented:

  • AWS::KMS::Key
  • AWS::KMS::Alias

@Morijarti Morijarti added aws:cloudformation AWS CloudFormation semver: patch Non-breaking changes which can be included in patch releases labels Oct 6, 2023
@github-actions
Copy link
github-actions bot commented Oct 6, 2023 •
edited
Loading

LocalStack Community integration with Pro

       2 files         2 suites   1h 14m 56s ⏱️
2 243 tests 1 741 ✔️ 502 💤 0 ❌
2 244 runs  1 741 ✔️ 503 💤 0 ❌

Results for commit 60d461d.

♻️ This comment has been updated with latest results.

pinzon
pinzon approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member
@pinzon pinzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Morijarti
Merge branch 'master' into feat/kms_cf
9d04906 
# Conflicts:
#	localstack/services/cloudformation/resource_provider.py
@coveralls
Copy link
coveralls commented Oct 7, 2023 •
edited
Loading

Coverage Status

coverage: 82.943% (+0.04%) from 82.899% when pulling 60d461d on feat/kms_cf into 7fc2ccc on master.

@Morijarti
Merge branch 'master' into feat/kms_cf
b5b9bd2
@Morijarti
Merge branch 'master' into feat/kms_cf
60d461d 
# Conflicts:
#	localstack/services/cloudformation/resource_provider.py
@Morijarti Morijarti merged commit 99708f4 into master Oct 10, 2023
@Morijarti Morijarti deleted the feat/kms_cf branch October 10, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinzon pinzon pinzon approved these changes

@sannya-singal sannya-singal Awaiting requested review from sannya-singal

@silv-io silv-io Awaiting requested review from silv-io

@dominikschubert dominikschubert Awaiting requested review from dominikschubert

@simonrw simonrw Awaiting requested review from simonrw

Assignees
No one assigned
Labels
aws:cloudformation AWS CloudFormation semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Morijarti @coveralls @pinzon
0