8000 Fix lambda filesystem permissions by joe4dev · Pull Request #9292 · localstack/localstack · GitHub
[go: up one dir, main page]

Skip to content

Fix lambda filesystem permissions #9292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Conversation

joe4dev
Copy link
Member
@joe4dev joe4dev commented Oct 4, 2023

Depends on localstack/lambda-runtime-init#22

Motivation

Addresses #8897

Changes

  • Use new Lambda runtime init Go releases
  • Disable snapshot skip for permissions in tmp directory introspection because that will be supported with the new init changes.
  • (unrelated) Update API visibility of Lambda configuration (recently updated in docs)

Testing

See companion ext PR https://github.com/localstack/localstack-ext/pull/2165

sidenote: The community introspection tests (e.g., tests.aws.services.lambda_.test_lambda.TestLambdaBehavior.test_runtime_introspection_x86) asserting the user changes fail when debugging the Lambda init because disabling dropping privileges in debug mode also disables these chown fixes.

TODO

  • Bump localstack/services/lambda_/packages.py:LAMBDA_RUNTIME_DEFAULT_VERSION once released

@joe4dev joe4dev added the semver: patch Non-breaking changes which can be included in patch releases label Oct 4, 2023
@joe4dev joe4dev added this to the 3.0 milestone Oct 4, 2023
@joe4dev joe4dev self-assigned this Oct 4, 2023
@joe4dev joe4dev changed the title Remove snapshot skips for fixed tmp permissions Fix lambda filesystem permissions Oct 4, 2023
@github-actions
Copy link
github-actions bot commented Oct 4, 2023

LocalStack Community integration with Pro

       2 files         2 suites   1h 19m 54s ⏱️
2 254 tests 1 753 ✔️ 501 💤 0
2 255 runs  1 753 ✔️ 502 💤 0

Results for commit 2a70a9c.

♻️ This comment has been updated with latest results.

@joe4dev joe4dev force-pushed the fix-lambda-filesystem-permissions branch from 0681b00 to 2a70a9c Compare October 16, 2023 13:49
@coveralls
Copy link

Coverage Status

coverage: 82.99%. remained the same when pulling 2a70a9c on fix-lambda-filesystem-permissions into 3d1f104 on master.

@joe4dev joe4dev marked this pull request as ready for review October 16, 2023 14:51
@joe4dev joe4dev merged commit 4858978 into master Oct 17, 2023
@joe4dev joe4dev deleted the fix-lambda-filesystem-permissions branch October 17, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0