8000 Fix layer version handling for external Lambda layers by joe4dev · Pull Request #9286 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

Fix layer version handling for external Lambda layers #9286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2023
Merged

Fix layer version handling for external Lambda layers #9286

merged 1 commit into from
Oct 6, 2023

Conversation

joe4dev
Copy link
Member
@joe4dev joe4dev commented Oct 4, 2023 •
edited
Loading

Motivation

Addresses a support request.

Fixes a bug where fetching external layers broke when using multiple versions of the same layer.

Changes

Handle multiple versions of the same layer when fetching external layers.

Testing

Added in companion ext PR: https://github.com/localstack/localstack-ext/pull/2163

Discussion

The logic starts to get quite complex here. Some thoughts for the future:

  • a) Using an internal service call with added cross-account support could simplify this logic here quite a bit. This requires IAM support, which was not present at the moment we implemented this initial version.
  • b) The layer fetcher could return a layer version. However, this would break up the logic between community and ext.

@joe4dev joe4dev added the semver: patch Non-breaking changes which can be included in patch releases label Oct 4, 2023
@joe4dev joe4dev added this to the 3.0 milestone Oct 4, 2023
@joe4dev joe4dev self-assigned this Oct 4, 2023
@joe4dev joe4dev requested a review from dfangl as a code owner October 4, 2023 13:27
@github-actions
Copy link
github-actions bot commented Oct 4, 2023

LocalStack Community integration with Pro

       2 files         2 suites   1h 21m 56s ⏱️
2 232 tests 1 740 ✔️ 492 💤 0 ❌
2 233 runs  1 740 ✔️ 493 💤 0 ❌

Results for commit 7908925.

dominikschubert
dominikschubert approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member
@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for jumping on this

@joe4dev joe4dev merged commit 0aea7e2 into master Oct 6, 2023
@joe4dev joe4dev deleted the fix-external-lambda-layer-multiple-versions branch October 6, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikschubert dominikschubert dominikschubert approved these changes

@dfangl dfangl Awaiting requested review from dfangl

Assignees

@joe4dev joe4dev

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@joe4dev @dominikschubert
0