8000 Fix running LS for tests in the new in_memory_localstack plugin by dfangl · Pull Request #9150 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

Fix running LS for tests in the new in_memory_localstack plugin #9150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Fix running LS for tests in the new in_memory_localstack plugin #9150

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f876f9b
Use pytest_runtestloop instead of pytest_sessionstart
dfangl Sep 14, 2023
20d041c
fix nits
dfangl Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion localstack/testing/pytest/in_memory_localstack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ def pytest_configure(config):
from localstack.constants import ENV_INTERNAL_TEST_RUN

LOG = logging.getLogger(__name__)
LOG.info("Pytest plugin for in-memory-localstack session loaded.")

if localstack_config.is_collect_metrics_mode():
pytest_plugins = "localstack.testing.pytest.metric_collection"
Expand All @@ -42,7 +43,7 @@ def pytest_addoption(parser: Parser, pluginmanager: PytestPluginManager):


@pytest.hookimpl(tryfirst=True)
def pytest_sessionstart(session: Session):
def pytest_runtestloop(session: Session):
if not session.config.option.start_localstack:
return

Expand Down
0