8000 add resourcegroups validated tests by bentsku · Pull Request #9140 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

add resourcegroups validated tests #9140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 13, 2023
Merged

add resourcegroups validated tests #9140

merged 3 commits into from
Sep 13, 2023

Conversation

bentsku
Copy link
Contributor
@bentsku bentsku commented Sep 13, 2023

Motivation

We did not have validated tests for the ResourceGroups service.

We would like to have more validated tests, especially covering the core operations and functionality (being able to query certain resources which have certain tags, or resources from a CloudFormation stack).

Resources:

Changes

Added AWS validated tests for ListGroupResources for tag based queries and cloudformation based queries. One test also covering SearchResources, which offers the same functionality without created a group.

@bentsku bentsku added aws:resourcegroups AWS Resource Groups semver: patch Non-breaking changes which can be included in patch releases labels Sep 13, 2023
@bentsku bentsku self-assigned this Sep 13, 2023
@coveralls
Copy link

Coverage Status

coverage: 79.851% (-0.3%) from 80.119% when pulling bd84478 on add-resourcegroups-tests into 6c91207 on master.

@github-actions
Copy link

LocalStack Community integration with Pro

       2 files         2 suites   1h 16m 34s ⏱️
2 205 tests 1 706 ✔️ 499 💤 0 ❌
2 206 runs  1 706 ✔️ 500 💤 0 ❌

Results for commit bd84478.

dominikschubert
dominikschubert approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member
@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Pity that we don't yet support the actually useful methods in that service 😞

@bentsku
Copy link
Contributor Author
bentsku commented Sep 13, 2023

Pity that we don't yet support the actually useful methods in that service 😞

Yeah, agree. I do think it will require substantial changes in our architecture to support though. For the tag based queries, we would need some kind of global tag database (could even use sqlite or something?) for every single resource supported by resourcegroups. A start would be to use the same instance of the TaggingService for all services instead of one per service, and also the reconciliation between moto resources (which have some kind of tagger service, but it might be per service as well...) and ours might be tricky. But I would really like something like that!

For CloudFormation queries, it might be a bit more straightforward?

@bentsku bentsku merged commit 466bfed into master Sep 13, 2023
@bentsku bentsku deleted the add-resourcegroups-tests branch September 13, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikschubert dominikschubert dominikschubert approved these changes

Assignees

@bentsku bentsku

Labels
aws:resourcegroups AWS Resource Groups semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bentsku @coveralls @dominikschubert
0