8000 implement S3 cross account across all operations by bentsku · Pull Request #9121 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

implement S3 cross account across all operations #9121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 13, 2023
Merged

implement S3 cross account across all operations #9121

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
08f7ab7
make s3 cross account compatible
bentsku Sep 12, 2023
2d68f2c
fix s3 notification store access
bentsku Sep 12, 2023
ab0d60d
fix stream store access
bentsku Sep 12, 2023
6658e77
fix get_store call in current provider
bentsku Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading < 8000 /div>
Diff view
Diff view
Prev Previous commit
Next Next commit
fix stream store access
  • Loading branch information
@bentsku
bentsku committed Sep 13, 2023
commit ab0d60d8e8180c5ea0bdae5b0e725f0723734b56
3 changes: 2 additions & 1 deletion localstack/services/s3/provider_stream.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,8 @@ def put_object(
response[f"Checksum{key_object.checksum_algorithm.upper()}"] = key_object.checksum_value

bucket_lifecycle_configurations = self.get_store(
context.account_id, context.region
moto_bucket.account_id,
moto_bucket.region_name,
).bucket_lifecycle_configuration
if (bucket_lifecycle_config := bucket_lifecycle_configurations.get(request["Bucket"])) and (
rules := bucket_lifecycle_config.get("Rules")
Expand Down
0