8000 Fix deletion of AWS::IAM::Policy by dominikschubert · Pull Request #9092 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

Fix deletion of AWS::IAM::Policy #9092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 12, 2023
Merged

Fix deletion of AWS::IAM::Policy #9092

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
85a9a32
skip instead of xfail
dominikschubert Sep 7, 2023
0c06af2
add test for blocked delete
dominikschubert Sep 7, 2023
9ea1814
fix AWS::IAM::Policy
dominikschubert Sep 7, 2023
c2243b0
improve logic around failing resource action a bit
dominikschubert Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
skip instead of xfail
  • Loading branch information
@dominikschubert
dominikschubert committed Sep 7, 2023
commit 85a9a324699ba1c7fd12653d1b185c5ad6757dc7
20 changes: 10 additions & 10 deletions tests/aws/services/cloudformation/api/test_update_stack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def test_update_using_template_url(deploy_cfn_template, s3_create_bucket, aws_cl


@markers.aws.validated
@pytest.mark.xfail(reason="Not supported")
@pytest.mark.skip(reason="Not supported")
def test_update_with_previous_template(deploy_cfn_template, aws_client):
stack = deploy_cfn_template(
template_path=os.path.join(
Expand All @@ -77,8 +77,8 @@ def test_update_with_previous_template(deploy_cfn_template, aws_client):
aws_client.cloudformation.get_waiter("stack_update_complete").wait(StackName=stack.stack_name)


@markers.aws.validated
@pytest.mark.xfail(reason="Not raising the correct error")
@markers.aws.needs_fixing
@pytest.mark.skip(reason="templates are not partially not valid => re-evaluate")
@pytest.mark.parametrize(
"capability",
[
Expand Down Expand Up @@ -123,7 +123,7 @@ def test_update_with_capabilities(capability, deploy_cfn_template, snapshot, aws


@markers.aws.validated
@pytest.mark.xfail(reason="Not raising the correct error")
@pytest.mark.skip(reason="Not raising the correct error")
def test_update_with_resource_types(deploy_cfn_template, snapshot, aws_client):
template = load_file(
os.path.join(os.path.dirname(__file__), "../../../templates/sns_topic_parameter.yml")
Expand Down Expand Up @@ -166,7 +166,7 @@ def test_update_with_resource_types(deploy_cfn_template, snapshot, aws_client):


@markers.aws.validated
@pytest.mark.xfail(reason="Update value not being applied")
@pytest.mark.skip(reason="Update value not being applied")
def test_set_notification_arn_with_update(deploy_cfn_template, sns_create_topic, aws_client):
template = load_file(
os.path.join(os.path.dirname(__file__), "../../../templates/sns_topic_parameter.yml")
Expand All @@ -191,7 +191,7 @@ def test_set_notification_arn_with_update(deploy_cfn_template, sns_create_topic,


@markers.aws.validated
@pytest.mark.xfail(reason="Update value not being applied")
@pytest.mark.skip(reason="Update value not being applied")
def test_update_tags(deploy_cfn_template, aws_client):
template = load_file(
os.path.join(os.path.dirname(__file__), "../../../templates/sns_topic_parameter.yml")
Expand Down Expand Up @@ -220,7 +220,7 @@ def test_update_tags(deploy_cfn_template, aws_client):


@markers.aws.validated
@pytest.mark.xfail(reason="The correct error is not being raised")
@pytest.mark.skip(reason="The correct error is not being raised")
def test_no_template_error(deploy_cfn_template, snapshot, aws_client):
template = load_file(
os.path.join(os.path.dirname(__file__), "../../../templates/sns_topic_parameter.yml")
Expand Down Expand Up @@ -276,7 +276,7 @@ def test_update_with_previous_parameter_value(deploy_cfn_template, snapshot, aws


@markers.aws.validated
@pytest.mark.xfail(reason="The correct error is not being raised")
@pytest.mark.skip(reason="The correct error is not being raised")
def test_update_with_role_without_permissions(
deploy_cfn_template, snapshot, create_role, aws_client
):
Expand Down Expand Up @@ -315,7 +315,7 @@ def test_update_with_role_without_permissions(


@markers.aws.validated
@pytest.mark.xfail(reason="The correct error is not being raised")
@pytest.mark.skip(reason="The correct error is not being raised")
def test_update_with_invalid_rollback_configuration_errors(
deploy_cfn_template, snapshot, aws_client
):
Expand Down Expand Up @@ -358,7 +358,7 @@ def test_update_with_invalid_rollback_configuration_errors(


@markers.aws.validated
@pytest.mark.xfail(reason="The update value is not being applied")
@pytest.mark.skip(reason="The update value is not being applied")
def test_update_with_rollback_configuration(deploy_cfn_template, aws_client):

aws_client.cloudwatch.put_metric_alarm(
Expand Down
0