8000 implement S3 BucketInventoryConfiguration CRUD operations by bentsku · Pull Request #8696 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

implement S3 BucketInventoryConfiguration CRUD operations #8696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 14, 2023
Merged

implement S3 BucketInventoryConfiguration CRUD operations #8696

merged 3 commits into from
Jul 14, 2023

Conversation

bentsku
Copy link
Contributor
@bentsku bentsku commented Jul 13, 2023 •
edited
Loading

This PR partly implements #8694, at least the mocking part. We were actually not supporting any CRUD operations, as it was not implemented in moto.

Also made use of the context in every get_store call, as we should remove any use of the threadlocal and make use of the nicely provided context.

TODO

  • implement Get/Put/List/Delete, happy path
  • implement validation and negative testing

Added operations:

  • PutBucketInventoryConfiguration
  • ListBucketInventoryConfigurations
  • GetBucketInventoryConfiguration
  • DeleteBucketInventoryConfiguration

@bentsku bentsku added semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases aws:s3 Amazon Simple Storage Service labels Jul 13, 2023
@bentsku bentsku self-assigned this Jul 13, 2023
@bentsku bentsku added this to the 2.2 milestone Jul 13, 2023
@bentsku bentsku changed the title first iteration, no negative testing/validation implement S3 BucketInventoryConfiguration mocking Jul 13, 2023
@coveralls
Copy link
coveralls commented Jul 13, 2023 •
edited
Loading

Coverage Status

coverage: 82.293% (+0.02%) from 82.278% when pulling 4a8cac6 on fix-inventory-report into 015e39e on master.

@github-actions
Copy link
github-actions bot commented Jul 13, 2023 •
edited
Loading

LocalStack Community integration with Pro

       2 files         2 suites   1h 27m 58s ⏱️
2 234 tests 1 892 ✔️ 342 💤 0 ❌
2 235 runs  1 892 ✔️ 343 💤 0 ❌

Results for commit 4a8cac6.

♻️ This comment has been updated with latest results.

@bentsku bentsku marked this pull request as ready for review July 13, 2023 23:57
@bentsku bentsku requested 8000 review from macnev2013 and thrau as code owners July 13, 2023 23:57
macnev2013
macnev2013 approved these changes Jul 14, 2023
View reviewed changes
@macnev2013
Copy link
Contributor

Awesome changes. LGTM 🚀

@bentsku bentsku force-pushed the fix-inventory-report branch from 02727ab to 4a8cac6 Compare July 14, 2023 15:16
@bentsku bentsku merged commit 5320b14 into master Jul 14, 2023
@bentsku bentsku deleted the fix-inventory-report branch July 14, 2023 16:25
@bentsku bentsku changed the title implement S3 BucketInventoryConfiguration mocking implement S3 BucketInventoryConfiguration CRUD operations Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macnev2013 macnev2013 macnev2013 approved these changes

@thrau thrau Awaiting requested review from thrau

Assignees

@bentsku bentsku

Labels
aws:s3 Amazon Simple Storage Service semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@bentsku @coveralls @macnev2013
0