8000 fix schedule cron conversion in events by ackdav · Pull Request #8692 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

fix schedule cron conversion in events #8692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2023
Merged

fix schedule cron conversion in events #8692

merged 1 commit into from
Jul 13, 2023

Conversation

ackdav
Copy link
Member
@ackdav ackdav commented Jul 13, 2023

This PR fixes a cron syntax error. Currently if you schedule an events rule hourly or daily, it will execute every minute. This is due to cron's syntax, which will match every minute due to the *.
The following resource helps to understand cron syntax: https://crontab.guru/every-1-hour

Thanks to @whummer for the help in finding this.

@ackdav ackdav added the semver: patch Non-breaking changes which can be included in patch releases label Jul 13, 2023
@ackdav ackdav added this to the 2.2 milestone Jul 13, 2023
@ackdav ackdav self-assigned this Jul 13, 2023
@github-actions
Copy link

LocalStack Community integration with Pro

       2 files         2 suites   1h 37m 5s ⏱️
2 223 tests 1 888 ✔️ 335 💤 0 ❌
2 224 runs  1 888 ✔️ 336 💤 0 ❌

Results for commit ac2f78b.

dominikschubert
dominikschubert approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member
@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

@ackdav ackdav merged commit 7f290f7 into master Jul 13, 2023
@ackdav ackdav deleted the fix_schedule_cron_conversion branch July 13, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikschubert dominikschubert dominikschubert approved these changes

@dfangl dfangl Awaiting requested review from dfangl

Assignees

@ackdav ackdav

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@ackdav @dominikschubert
0