8000 Add basic invoke test for AWS::Lambda::Function with code package on S3 by dominikschubert · Pull Request #8632 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

Add basic invoke test for AWS::Lambda::Function with code package on S3 #8632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2023
Merged

Add basic invoke test for AWS::Lambda::Function with code package on S3 #8632

merged 1 commit into from
Jul 12, 2023

Conversation

dominikschubert
Copy link
Member

We didn't really have any tests that used AWS::Lambda::Function with the code uploaded to an s3 bucket. Instead the tests usually directly embedded the code in the template.

@dominikschubert dominikschubert self-assigned this Jul 5, 2023
@dominikschubert dominikschubert added the semver: patch Non-breaking changes which can be included in patch releases label Jul 5, 2023
@coveralls
Copy link

Coverage Status

coverage: 82.713% (-0.03%) from 82.747% when pulling e8e7aa0 on cfn-lambda-code-s3 into b1dffa7 on master.

@github-actions
Copy link
github-actions bot commented Jul 5, 2023

LocalStack Community integration with Pro

       2 files         2 suites   1h 34m 24s ⏱️
2 177 tests 1 846 ✔️ 331 💤 0 ❌
2 178 runs  1 846 ✔️ 332 💤 0 ❌

Results for commit e8e7aa0.

@dominikschubert dominikschubert added this to the 2.2 milestone Jul 12, 2023
@dominikschubert dominikschubert requested a review from joe4dev July 12, 2023 09:59
@dominikschubert dominikschubert marked this pull request as ready for review July 12, 2023 09:59
simonrw
simonrw approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor
@simonrw simonrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, glad we have coverage of this feature now

@dominikschubert dominikschubert merged commit a000683 into master Jul 12, 2023
@dominikschubert dominikschubert deleted the cfn-lambda-code-s3 branch July 12, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonrw simonrw simonrw approved these changes

@joe4dev joe4dev Awaiting requested review from joe4dev

@pinzon pinzon Awaiting requested review from pinzon

Assignees

@dominikschubert dominikschubert

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@dominikschubert @coveralls @simonrw
0