8000 xfail flaky ssm describe_parameters test by alexrashed · Pull Request #8631 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

xfail flaky ssm describe_parameters test #8631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2023
Merged

xfail flaky ssm describe_parameters test #8631

merged 1 commit into from
Jul 5, 2023

Conversation

alexrashed
Copy link
Member

This PR aims at unblocking the pipeline on master by marking the currently failing SSM test with xfail.
This is just a temprary measure until getmoto/moto#6484 is merged.
Until then, SSM's DescribeParameters might break if PutParameters was used without a parameter type before (which is an invalid request, according to the service specifications).

@alexrashed alexrashed added the semver: patch Non-breaking changes which can be included in patch releases label Jul 5, 2023
@alexrashed alexrashed requested a review from bentsku July 5, 2023 19:36
bentsku
bentsku approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor
@bentsku bentsku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks so much for taking care of it, nice to read about the root cause. Thanks for the quick xfail before the real fix in moto.

@alexrashed alexrashed merged commit b1dffa7 into master Jul 5, 2023
@alexrashed alexrashed deleted the unblock-pipeline branch July 5, 2023 20:10
calvernaz pushed a commit that referenced this pull request Jul 5, 2023
@alexrashed @calvernaz
xfail flaky ssm describe_parameters test (#8631)
2187a92
viren-nadkarni added a commit that referenced this pull request Jul 10, 2023
@viren-nadkarni
Revert "xfail flaky ssm describe_parameters test (#8631)"
7627471 
This reverts commit b1dffa7.
@viren-nadkarni viren-nadkarni mentioned this pull request Jul 10, 2023
Merged
@dfangl dfangl added this to the 2.2 milestone Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bentsku bentsku bentsku approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert

Assignees
No one assigned
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@alexrashed @bentsku @dfangl
0