E679 Fix error with non-existent policy for AttachRolePolicy operation by dfangl · Pull Request #8615 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

Fix error with non-existent policy for AttachRolePolicy operation #8615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 12, 2023
Merged

Fix error with non-existent policy for AttachRolePolicy operation #8615

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6f7bdd8
add aws validated and snapshotted tests + fixes for attach policy errors
dfangl Jul 4, 2023
45adabb
fix arn parsing for managed policies
dfangl Jul 11, 2023
de72fa9
fix snapshots
dfangl Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix snapshots
  • Loading branch information
@dfangl
dfangl committed Jul 11, 2023
commit de72fa9b17751362f0ff6a96d6b32698155d0ac4
14 changes: 7 additions & 7 deletions tests/integration/cloudformation/resources/test_iam.snapshot.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,25 +18,25 @@
}
},
"tests/integration/cloudformation/resources/test_iam.py::test_managed_policy_with_empty_resource": {
"recorded-date": "05-09-2022, 10:01:53",
"recorded-date": "11-07-2023, 18:10:41",
"recorded-content": {
"outputs": {
"PolicyArn": "arn:aws:iam::111111111111:policy/<resource:1>",
"StreamARN": "arn:aws:dynamodb:<region>:111111111111:table/<resource:3>/stream/<resource:2>",
"TableARN": "arn:aws:dynamodb:<region>:111111111111:table/<resource:3>",
"TableName": "<resource:3>"
"PolicyArn": "arn:aws:iam::111111111111:policy/<policy-name:1>",
"StreamARN": "arn:aws:dynamodb:<region>:111111111111:table/<resource:2>/stream/<resource:1>",
"TableARN": "arn:aws:dynamodb:<region>:111111111111:table/<resource:2>",
"TableName": "<resource:2>"
},
"managed_policy": {
"Policy": {
"Arn": "arn:aws:iam::111111111111:policy/<resource:1>",
"Arn": "arn:aws:iam::111111111111:policy/<policy-name:1>",
"AttachmentCount": 0,
"CreateDate": "datetime",
"DefaultVersionId": "v1",
"IsAttachable": true,
"Path": "/",
"PermissionsBoundaryUsageCount": 0,
"PolicyId": "<policy-id:1>",
"PolicyName": "<resource:1>",
"PolicyName": "<policy-name:1>",
"Tags": [],
"UpdateDate": "datetime"
},
Expand Down
14 changes: 7 additions & 7 deletions tests/integration/cloudformation/resources/test_sam.snapshot.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,22 @@
{
"tests/integration/cloudformation/resources/test_sam.py::test_sam_policies": {
"recorded-date": "02-06-2022, 13:13:20",
"recorded-date": "11-07-2023, 18:08:53",
"recorded-content": {
"list_attached_role_policies": {
"AttachedPolicies": [
{
"PolicyName": "AWSLambdaBasicExecutionRole",
"PolicyArn": "arn:aws:iam::aws:policy/service-role/AWSLambdaBasicExecutionRole"
"PolicyArn": "arn:aws:iam::aws:policy/service-role/<policy-name:1>",
"PolicyName": "<policy-name:1>"
},
{
"PolicyName": "AmazonSNSFullAccess",
"PolicyArn": "arn:aws:iam::aws:policy/AmazonSNSFullAccess"
"PolicyArn": "arn:aws:iam::aws:policy/<policy-name:2>",
"PolicyName": "<policy-name:2>"
}
],
"IsTruncated": false,
"ResponseMetadata": {
"HTTPStatusCode": 200,
"HTTPHeaders": {}
"HTTPHeaders": {},
"HTTPStatusCode": 200
}
}
}
Expand Down
0