8000 Additional debugging for network connection failure by dfangl · Pull Request #8602 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

Additional debugging for network connection failure #8602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 4, 2023
Merged

Additional debugging for network connection failure #8602

merged 3 commits into from
Jul 4, 2023

Conversation

dfangl
Copy link
Member
@dfangl dfangl commented Jul 3, 2023 •
edited
Loading

Motivation

  • We got the case where we could not find the container in the list of connected endpoints in the network right after start with this network. If this happens, we want all the information we can get.

Changes

  • Add additional debug logs in error case
  • Proper defaults for different container configuration flags.
  • Sneaked in using new clients for retrieving code archives

@dfangl
create additional debug logs if container is not connected to network…
787ee6f 
… after start, add proper defaults in container configuration
@dfangl dfangl requested a review from dominikschubert as a code owner July 3, 2023 10:18
@dfangl dfangl added the semver: patch Non-breaking changes which can be included in patch releases label Jul 3, 2023
@coveralls
Copy link
coveralls commented Jul 3, 2023 •
edited
Loading

Coverage Status

coverage: 82.726% (+0.008%) from 82.718% when pulling 17dc21c on additional-debug-logs-lambda into 3d8dd50 on master.

@dfangl dfangl requested a review from joe4dev as a code owner July 3, 2023 11:16
@github-actions
Copy link
github-actions bot commented Jul 3, 2023

LocalStack Commun 8000 ity integration with Pro

       2 files         2 suites   1h 24m 50s ⏱️
2 171 tests 1 842 ✔️ 329 💤 0 ❌
2 172 runs  1 842 ✔️ 330 💤 0 ❌

Results for commit 17dc21c.

dominikschubert
dominikschubert approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member
@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's hope this will help shed some light on the recent docker issues

localstack/services/awslambda/invocation/lambda_models.py
@@ -168,7 +165,7 @@ def _download_archive_to_file(self, target_file: IO) -> None:

:param target_file: File the code archive should be downloaded into (IO object)
"""
s3_client: "S3Client" = aws_stack.connect_to_service("s3", region_name="us-east-1")
s3_client = connect_to(region_name="us-east-1").s3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sneaky

@dfangl dfangl merged commit 2408239 into master Jul 4, 2023
@dfangl dfangl deleted the additional-debug-logs-lambda branch July 4, 2023 12:17
@dfangl dfangl added this to the 2.2 milestone Jul 17, 2023
@thrau thrau mentioned this pull request Aug 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikschubert dominikschubert dominikschubert approved these changes

@joe4dev joe4dev Awaiting requested review from joe4dev

Assignees
No one assigned
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@dfangl @coveralls @dominikschubert
0