test cfn mappings

localstack · dominikschubert · Jun 28, 2023 · Jun 7, 2023 · Jun 12, 2023 · Jun 12, 2023
commit c8af1c8bf0b34eac978d02149ca3e6fb217c05c9
diff --git a/tests/integration/cloudformation/engine/test_mappings.py b/tests/integration/cloudformation/engine/test_mappings.py
@@ -121,4 +121,30 @@ def test_mapping_maximum_nesting_depth(self, aws_client, cleanups, snapshot):
                     {"ParameterKey": "TopicNameSuffixSelector", "ParameterValue": "A"},
                 ],
             )
-        snapshot.match("mapping_nonexisting_key_exc", e.value.response)
+        snapshot.match("mapping_maximum_level_exc", e.value.response)
+
+    @pytest.mark.aws_validated
+    def test_mapping_minimum_nesting_depth(self, aws_client, cleanups, snapshot):
+        """
+        Tries to deploy a template containing a mapping with a nesting depth of 1.
+        The required depth is 2, so it should fail for a single level
+        """
+        topic_name = f"test-topic-{short_uid()}"
+        stack_name = f"test-stack-{short_uid()}"
+        cleanups.append(lambda: aws_client.cloudformation.delete_stack(StackName=stack_name))
+        template_body = load_file(
+            os.path.join(THIS_DIR, "../../templates/mappings/simple-mapping-single-level.yaml")
+        )
+
+        with pytest.raises(aws_client.cloudformation.exceptions.ClientError) as e:
+            aws_client.cloudformation.create_change_set(
+                StackName=stack_name,
+                ChangeSetName="initial",
+                TemplateBody=template_body,
+                ChangeSetType="CREATE",
+                Parameters=[
+                    {"ParameterKey": "TopicName", "ParameterValue": topic_name},
+                    {"ParameterKey": "TopicNameSuffixSelector", "ParameterValue": "A"},
+                ],
+            )
+        snapshot.match("mapping_minimum_level_exc", e.value.response)
diff --git a/tests/integration/cloudformation/engine/test_mappings.snapshot.json b/tests/integration/cloudformation/engine/test_mappings.snapshot.json
@@ -1,6 +1,6 @@
 {
   "tests/integration/cloudformation/engine/test_mappings.py::TestCloudFormationMappings::test_mapping_with_nonexisting_key": {
-    "recorded-date": "12-06-2023, 11:54:01",
+    "recorded-date": "12-06-2023, 16:47:23",
     "recorded-content": {
       "mapping_nonexisting_key_exc": {
         "Error": {
@@ -16,7 +16,7 @@
     }
   },
   "tests/integration/cloudformation/engine/test_mappings.py::TestCloudFormationMappings::test_mapping_with_invalid_refs": {
-    "recorded-date": "12-06-2023, 11:54:01",
+    "recorded-date": "12-06-2023, 16:47:24",
     "recorded-content": {
       "mapping_invalid_ref_exc": {
         "Error": {
@@ -32,9 +32,9 @@
     }
   },
   "tests/integration/cloudformation/engine/test_mappings.py::TestCloudFormationMappings::test_mapping_maximum_nesting_depth": {
-    "recorded-date": "12-06-2023, 11:54:02",
+    "recorded-date": "12-06-2023, 16:47:24",
     "recorded-content": {
-      "mapping_nonexisting_key_exc": {
+      "mapping_maximum_level_exc": {
         "Error": {
           "Code": "ValidationError",
           "Message": "Template format error: Every Mappings attribute must be a String or a List.",
@@ -46,5 +46,21 @@
         }
       }
     }
+  },
+  "tests/integration/cloudformation/engine/test_mappings.py::TestCloudFormationMappings::test_mapping_minimum_nesting_depth": {
+    "recorded-date": "12-06-2023, 16:47:25",
+    "recorded-content": {
+      "mapping_minimum_level_exc": {
+        "Error": {
+          "Code": "ValidationError",
+          "Message": "Template format error: Every Mappings member A must be a map",
+          "Type": "Sender"
+        },
+        "ResponseMetadata": {
+          "HTTPHeaders": {},
+          "HTTPStatusCode": 400
+        }
+      }
+    }
   }
 }
diff --git a/tests/integration/templates/mappings/simple-mapping-single-level.yaml b/tests/integration/templates/mappings/simple-mapping-single-level.yaml
@@ -0,0 +1,21 @@
+Parameters:
+  TopicName:
+    Type: String
+
+  TopicNameSuffixSelector:
+    Type: String
+
+Resources:
+  MyTopic:
+    Type: AWS::SNS::Topic
+    Properties:
+      TopicName:
+        "Fn::Join":
+          - "-"
+          - - !Ref TopicName
+            - !FindInMap [TopicSuffixMap, !Ref TopicNameSuffixSelector]
+
+Mappings:
+  TopicSuffixMap:
+    A: suffix-a
+    B: suffix-b