8000 Fix lambda destination default retries by dominikschubert · Pull Request #7933 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

Fix lambda destination default retries #7933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 22, 2023
Merged

Fix lambda destination default retries #7933

merged 3 commits into from
Mar 22, 2023

Conversation

dominikschubert
Copy link
Member

By default Lambda should retry async event invocations 2 times. We didn't honor this and since max_retry_attempts was None this lead to an exception in the spawned thread and therefore was never actually retried.

Example:

lambda_client.put_function_event_invoke_config(FunctionName=function_name, DestinationConfig={"OnSuccess": {"Destination": some_arn}})

@dominikschubert dominikschubert requested a review from dfangl as a code owner March 22, 2023 18:10
@dominikschubert dominikschubert self-assigned this Mar 22, 2023
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests March 22, 2023 18:10 — with GitHub Actions Inactive
@github-actions
Copy link

LocalStack integration with Pro

       3 files  ±0         3 suites  ±0   1h 45m 35s ⏱️ + 9m 57s
1 844 tests +1  1 452 ✔️  - 1  392 💤 +2  0 ❌ ±0 
2 580 runs  +3  1 817 ✔️  - 1  763 💤 +4  0 ❌ ±0 

Results for commit 4ddc083. ± Comparison against base commit 805b4a5.

@dominikschubert dominikschubert merged commit 2946514 into master Mar 22, 2023
@dominikschubert dominikschubert deleted the fix_destination-default-retries branch March 22, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfangl dfangl dfangl approved these changes

Assignees

@dominikschubert dominikschubert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dominikschubert @dfangl
0