8000 v2 pipeline changes by alexrashed · Pull Request #7927 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

v2 pipeline changes #7927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexrashed merged 5 commits into from
Mar 23, 2023
Merged

v2 pipeline changes #7927

alexrashed merged 5 commits into from
Mar 23, 2023

Conversation

@alexrashed
Copy link
Member
@alexrashed alexrashed commented Mar 22, 2023 •
edited
Loading

This PR contains quite fundamental and breaking changes for LocalStack v2 (which have been announced in advance, most notibly in #7882).
It contains the following chanages:

  • The Dockerfile has been completely refactored such that it does not contain any LocalStack Pro code anymore.
    • This resolves a build-time circular dependency (which caused a lot of problems) and allows us to ship a community-only image (which is much smaller in size).
  • The CircleCI pipeline has been heavily refactored.
    • It does not perform any Pro smoke tests anymore.
    • It does not build or push localstack/localstack-light or localstack/localstack-full anymore.
    • It performs a dev-release of localstack-core after every successful build and publishes it on PyPi.
  • The release-helper.sh script, to simplify the release handling has been moved into this repository. /cc @thrau
  • All GitHub workflows have been refactored such that they do not use any deprecated GitHub workflow features anymore.
  • The RedHat smoke test pipeline and the example Dockerfile.rh has been removed for now (it was a test pipeline for Pro). /cc @whummer
  • The "Collect not Implemented" step in the CircleCI pipeline is not executed for Pro anymore (since the image does not contain any Pro package anymore). The Tinybird upload script has been slightly adjusted to allow only uploading results for LocalStack Community to Tinybird. See use new artifacts (pro) for Docs Update Workflow docs#516. /cc @steffyP

@alexrashed alexrashed temporarily deployed to localstack-ext-tests March 22, 2023 13:47 — with GitHub Actions Inactive
@alexrashed alexrashed temporarily deployed to localstack-ext-tests March 22, 2023 14:11 — with GitHub Actions Inactive
@github-actions
Copy link
8000 github-actions bot commented Mar 22, 2023 •
edited
Loading

LocalStack integration with Pro

       3 files  ±0         3 suites  ±0   1h 34m 11s ⏱️ - 13m 34s
1 838 tests ±0  1 447 ✔️  - 1  391 💤 +1  0 ❌ ±0 
2 574 runs  ±0  1 814 ✔️  - 1  760 💤 +1  0 ❌ ±0 

Results for commit 86abc71. ± Comparison against base commit 5f13258.

♻️ This comment has been updated with latest results.

@coveralls
Copy link
coveralls commented Mar 22, 2023

Coverage Status

Coverage: 85.039% (+0.1%) from 84.938% when pulling 86abc71 on v2-pipeline into 5f13258 on master.

@alexrashed alexrashed temporarily deployed to localstack-ext-tests March 22, 2023 15:13 — with GitHub Actions Inactive
@alexrashed alexrashed temporarily deployed to localstack-ext-tests March 23, 2023 07:29 — with GitHub Actions Inactive
@alexrashed alexrashed marked this pull request as ready for review March 23, 2023 08:52
@alexrashed alexrashed requested review from dfangl and thrau as code owners March 23, 2023 08:52
@alexrashed alexrashed temporarily deployed to localstack-ext-tests March 23, 2023 09:00 — with GitHub Actions Inactive
@alexrashed alexrashed temporarily deployed to localstack-ext-tests March 23, 2023 09:37 — with GitHub Actions Inactive
thrau
thrau approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member
@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 LGTM (praise offline)

@alexrashed alexrashed merged commit b4e4c5d into master Mar 23, 2023
@alexrashed alexrashed deleted the v2-pipeline branch March 23, 2023 10:27
@alexrashed alexrashed mentioned this pull request Apr 25, 2023
Merged
@alexrashed alexrashed mentioned this pull request Feb 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thrau thrau thrau approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert

@whummer whummer Awaiting requested review from whummer

@dfangl dfangl Awaiting requested review from dfangl

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alexrashed @coveralls @thrau
0