8000 Removing state serializer interfaces by giograno · Pull Request #7921 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

Removing state serializer interfaces #7921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2023
Merged

Removing state serializer interfaces #7921

merged 1 commit into from
Mar 23, 2023

Conversation

giograno
Copy link
Member

@giograno giograno temporarily deployed to localstack-ext-tests March 21, 2023 14:55 — with GitHub Actions Inactive
@github-actions
Copy link
github-actions bot commented Mar 21, 2023 •
edited
Loading

LocalStack integration with Pro

0 files   -        3  0 suites   - 3   0s ⏱️ - 1h 37m 29s
0 tests  - 1 837  0 ✔️  - 1 448  0 💤  - 389  0 ❌ ±0 
0 runs   - 2 573  0 ✔️  - 1 815  0 💤  - 758  0 ❌ ±0 

Results for commit 363aa90. ± Comparison against base commit aeb3000.

♻️ This comment has been updated with latest results.

@giograno giograno force-pushed the remove-setup-and-restore-persistence branch from 4308770 to 543b54b Compare March 21, 2023 17:27
@giograno giograno temporarily deployed to localstack-ext-tests March 21, 2023 17:27 — with GitHub Actions Inactive
@giograno giograno requested a review from thrau March 21, 2023 17:38
@giograno giograno force-pushed the remove-setup-and-restore-persistence branch from 543b54b to 363aa90 Compare March 21, 2023 18:46
@giograno giograno temporarily deployed to localstack-ext-tests March 21, 2023 18:46 — with GitHub Actions Inactive
@giograno giograno marked 8000 this pull request as ready for review March 21, 2023 19:04
@coveralls
Copy link

Coverage Status

Coverage: 84.948% (+0.03%) from 84.919% when pulling 363aa90 on remove-setup-and-restore-persistence into aeb3000 on master.

thrau
thrau approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member
@thrau thrau left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🧹

i'll target this into v2 since there's some other code removal there as well

@thrau thrau changed the base branch from master to v2 March 22, 2023 11:16
@giograno giograno temporarily deployed to localstack-ext-tests March 23, 2023 01:37 — with GitHub Actions Inactive
@alexrashed alexrashed merged commit a12e673 into v2 Mar 23, 2023
@alexrashed alexrashed deleted the remove-setup-and-restore-persistence branch March 23, 2023 13:46
alexrashed pushed a commit that referenced this pull request Mar 23, 2023
@giograno @alexrashed
Removing state serializer interfaces (#7921)
060ea65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thrau thrau thrau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@giograno @coveralls @thrau @alexrashed
0