8000 Add support for VPC endpoints for private API Gateway REST APIs by whummer · Pull Request #7905 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

Add support for VPC endpoints for private API Gateway REST APIs #7905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 21, 2023
Merged

Add support for VPC endpoints for private API Gateway REST APIs #7905

merged 8 commits into from
Mar 21, 2023

Conversation

whummer
Copy link
Member
@whummer whummer commented Mar 18, 2023 •
edited
Loading

Add support for VPC endpoints for private API Gateway REST APIs. See docs here.

These endpoints allow users to invoke REST APIs under the following endpoints:

http(s)://{rest-api-id}-{vpce-id}.execute-api.localhost.localstack.cloud:4566/{stage}

... in addition to the standard API GW invocation endpoints:

http(s)://{rest-api-id}.execute-api.localhost.localstack.cloud:4566/{stage}

A snapshot test has been added to cover the functionality.

More detailed description following soon..

@whummer whummer temporarily deployed to localstack-ext-tests March 18, 2023 21:54 — with GitHub Actions Inactive
@whummer whummer temporarily deployed to localstack-ext-tests March 18, 2023 22:36 — with GitHub Actions Inactive
whummer
whummer commented Mar 18, 2023
View reviewed changes
@github-actions
Copy link
github-actions bot commented Mar 19, 2023 •
edited
Loading

LocalStack integration with Pro

       3 files  ±  0         3 suites  ±0   1h 50m 48s ⏱️ + 18m 17s
1 838 tests +24  1 448 ✔️ +19  390 💤 +  5  0 ❌ ±0 
2 574 runs  +42  1 815 ✔️ +20  759 💤 +22  0 ❌ ±0 

Results for commit dbd6a3b. ± Comparison against base commit 5949082.

♻️ This comment has been updated with latest results.

@whummer whummer requested a review from dfangl as a code owner March 19, 2023 01:09
@whummer whummer temporarily deployed to localstack-ext-tests March 19, 2023 01:09 — with GitHub Actions Inactive
@whummer whummer changed the title Add support for VPC endpoints for private API Gateway REST APIs [wip] Add support for VPC endpoints for private API Gateway REST APIs Mar 19, 2023
@whummer whummer temporarily deployed to localstack-ext-tests March 19, 2023 12:36 — with GitHub Actions Inactive
@whummer whummer temporarily deployed to localstack-ext-tests March 19, 2023 14:54 — with GitHub Actions Inactive
@whummer whummer force-pushed the apigw-vpc-endpoint branch from 7a5d49d to 45465d7 Compare March 19, 2023 14:56
@whummer whummer temporarily deployed to localstack-ext-tests March 19, 2023 14:57 — with GitHub Actions Inactive
@whummer whummer force-pushed the apigw-vpc-endpoint branch from 45465d7 to 0c4c85e Compare March 19, 2023 14:58
@whummer whummer temporarily deployed to localstack-ext-tests March 19, 2023 14:58 — with GitHub Actions Inactive
@coveralls
Copy link
coveralls commented Mar 19, 2023 •
edited
Loading

Coverage Status

Coverage: 85.136% (+0.01%) from 85.121% when pulling dbd6a3b on apigw-vpc-endpoint into 5949082 on master.

@whummer whummer changed the title [wip] Add support for VPC endpoints for private API Gateway REST APIs Add support for VPC endpoints for private API Gateway REST APIs Mar 19, 2023
@whummer whummer temporarily deployed to localstack-ext-tests March 19, 2023 16:25 — with GitHub Actions Inactive
@whummer whummer temporarily deployed to localstack-ext-tests March 19, 2023 18:35 — with GitHub Actions Inactive
dfangl
dfangl reviewed Mar 19, 2023
View reviewed changes
@whummer whummer temporarily deployed to localstack-ext-tests March 20, 2023 11:27 — with GitHub Actions Inactive
@whummer whummer requested a review from bentsku March 20, 2023 18:07
bentsku
bentsku approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor
@bentsku bentsku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉 Thanks a lot for tackling this! It's so great to see how we can add functionality using 2 different services and it being so clear with ASF now. And so nice to see it AWS validated, and making it easier to fix the parity. Only one minor nit in the ec2 provider, but nothing blocking for me. 🚀

@whummer whummer temporarily deployed to localstack-ext-tests March 21, 2023 19:38 — with GitHub Actions Inactive
@whummer whummer merged commit 5f13258 into master Mar 21, 2023
@whummer whummer deleted the apigw-vpc-endpoint branch March 21, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfangl dfangl dfangl left review comments

@bentsku bentsku bentsku approved these changes

@viren-nadkarni viren-nadkarni Awaiting requested review from viren-nadkarni

@calvernaz calvernaz Awaiting requested review from calvernaz

@dominikschubert dominikschubert Awaiting requested review from dominikschubert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@whummer @coveralls @dfangl @bentsku
0