8000 Stop tracking the values of HOST* related envars by simonrw · Pull Request #7877 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

Stop tracking the values of HOST* related envars #7877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2023
Merged

Stop tracking the values of HOST* related envars #7877

merged 1 commit into from
Mar 15, 2023

Conversation

simonrw
Copy link
Contributor
@simonrw simonrw commented Mar 15, 2023

No description provided.

@simonrw simonrw self-assigned this Mar 15, 2023
@simonrw simonrw requested review from ackdav and thrau March 15, 2023 11:34
@simonrw simonrw temporarily deployed to localstack-ext-tests March 15, 2023 11:34 — with GitHub Actions Inactive
@simonrw simonrw marked this pull request as ready for review March 15, 2023 11:34
ackdav
ackdav approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member
@ackdav ackdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch 🚀 thx!

@github-actions
Copy link

LocalStack integration with Pro

       3 files  ±0         3 suites  ±0   1h 42m 3s ⏱️ -17s
1 798 tests ±0  1 416 ✔️ ±0  382 💤 ±0  0 ❌ ±0 
2 524 runs  ±0  1 790 ✔️ ±0  734 💤 ±0  0 ❌ ±0 

Results for commit f8ec8ea. ± Comparison against base commit 3cb5069.

@simonrw simonrw merged commit 61b2648 into master Mar 15, 2023
@simonrw simonrw deleted the stop-tracking-hostname-external-value branch March 15, 2023 13:57
@coveralls
Copy link

Coverage Status

Coverage: 85.118% (+0.008%) from 85.109% when pulling f8ec8ea on stop-tracking-hostname-external-value into 3cb5069 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ackdav ackdav ackdav approved these changes

@thrau thrau Awaiting requested review from thrau

Assignees

@simonrw simonrw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simonrw @coveralls @ackdav
0