8000 restructure python distributions by alexrashed · Pull Request #7730 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

restructure python distributions #7730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 27, 2023
Merged

restructure python distributions #7730

merged 7 commits into from
Feb 27, 2023

Conversation

alexrashed
Copy link
Member
@alexrashed alexrashed commented Feb 22, 2023 •
edited
Loading

This PR is a preparation for upcoming changes with v2 concerning the packaging and Docker image structure.
With this PR, the python distribution which is published from this repository is renamed from localstack to localstack-core.
It loses its dependency on our "extensions" distribution (which will resolve the build and release issues due to our cyclic dependency, and will introduce a clear separation between community and pro).
Some of the CLI / bootstrap tests have been moved to the extensions repo, since they were depending on them.

@alexrashed alexrashed temporarily deployed to localstack-ext-tests February 22, 2023 13:26 — with GitHub Actions Inactive
@github-actions
Copy link
github-actions bot commented Feb 22, 2023 •
edited
Loading

LocalStack integration with Pro

       3 files  ±0         3 suites  ±0   1h 31m 41s ⏱️ - 9m 7s
1 756 tests ±0  1 386 ✔️ +1  370 💤  - 1  0 ❌ ±0 
2 474 runs  ±0  1 762 ✔️ +1  712 💤  - 1  0 ❌ ±0 

Results for commit bd37086. ± Comparison against base commit 942bfed.

♻️ This comment has been updated with latest results.

@alexrashed alexrashed temporarily deployed to localstack-ext-tests February 22, 2023 13:54 — with GitHub Actions Inactive
@alexrashed alexrashed temporarily deployed to localstack-ext-tests February 22, 2023 14:00 — with GitHub Actions Inactive
@alexrashed alexrashed temporarily deployed to localstack-ext-tests February 22, 2023 14:05 — with GitHub Actions Inactive
thrau
thrau reviewed Feb 22, 2023
View reviewed changes
Copy link
Member
@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me! Just a couple of comments.

I wonder what we'll do about the CLI tests to get the coverage information?

@alexrashed
Copy link
Member Author

I wonder what we'll do about the CLI tests to get the coverage information?

@dfangl also raised concerns about the CLI tests (since we need to identify incompatibilities with Python < 3.10 asap).
This is why I re-introduced all CLI unit tests which do not rely on our extensions.

@coveralls
Copy link
coveralls commented Feb 22, 2023 •
edited
Loading

Coverage Status

Coverage: 84.979%. Remained the same when pulling dad4b3c on change-distributions into a820acf on master.

@alexrashed alexrashed temporarily deployed to localstack-ext-tests February 22, 2023 15:22 — with GitHub Actions Inactive
@alexrashed alexrashed temporarily deployed to localstack-ext-tests February 22, 2023 15:23 — with GitHub Actions Inactive
@alexrashed alexrashed marked this pull request as ready for review February 23, 2023 08:58
@alexrashed alexrashed requested a review from thrau February 23, 2023 08:59
thrau
thrau approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member
@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good now! Let's release and merge? ;)

@alexrashed alexrashed temporarily deployed to localstack-ext-tests February 24, 2023 12:51 — with GitHub Actions Inactive
@alexrashed alexrashed temporarily deployed to localstack-ext-tests February 27, 2023 07:37 — with GitHub Actions Inactive
@alexrashed alexrashed merged commit 145291f into master Feb 27, 2023
@alexrashed alexrashed deleted the change-distributions branch February 27, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thrau thrau thrau approved these changes

@dfangl dfangl Awaiting requested review from dfangl

@dominikschubert dominikschubert Awaiting requested review from dominikschubert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexrashed @coveralls @thrau
0