Add unit tests

localstack · viren-nadkarni · Nov 24, 2022 · Jan 2, 2023 · Jan 4, 2023 · Jan 4, 2023
commit 3f399c6de6ebdb730948e25ab31861de2131971d
diff --git a/localstack/services/stores.py b/localstack/services/stores.py
@@ -311,7 +311,7 @@ def reset(self):
         """
         # For safety, clear all referenced region bundles, if any
         for region_bundle in self.values():
-            region_bundle.reset()
+            region_bundle.reset(_reset_universal=True)
 
         self._universal.clear()
 

diff --git a/tests/unit/test_stores.py b/tests/unit/test_stores.py
@@ -18,24 +18,45 @@ def test_store_reset(self, sample_stores):
 
         store1.region_specific_attr.extend([1, 2, 3])
         store1.CROSS_REGION_ATTR.extend(["a", "b", "c"])
+        store1.CROSS_ACCOUNT_ATTR.extend([100j, 200j, 300j])
         store2.region_specific_attr.extend([4, 5, 6])
+        store2.CROSS_ACCOUNT_ATTR.extend([400j])
         store3.region_specific_attr.extend([7, 8, 9])
         store3.CROSS_REGION_ATTR.extend([0.1, 0.2, 0.3])
+        store3.CROSS_ACCOUNT_ATTR.extend([500j])
+
+        # Ensure all stores are affected by cross-account attributes
+        assert store1.CROSS_ACCOUNT_ATTR == [100j, 200j, 300j, 400j, 500j]
+        assert store2.CROSS_ACCOUNT_ATTR == [100j, 200j, 300j, 400j, 500j]
+        assert store3.CROSS_ACCOUNT_ATTR == [100j, 200j, 300j, 400j, 500j]
+
+        assert store1.CROSS_ACCOUNT_ATTR.pop() == 500j
+
+        assert store2.CROSS_ACCOUNT_ATTR == [100j, 200j, 300j, 400j]
+        assert store3.CROSS_ACCOUNT_ATTR == [100j, 200j, 300j, 400j]
 
         # Ensure other account stores are not affected by RegionBundle reset
+        # Ensure cross-account attributes are not affected by RegionBundle reset
         sample_stores[account1].reset()
 
         assert store1.region_specific_attr == []
         assert store1.CROSS_REGION_ATTR == []
+        assert store1.CROSS_ACCOUNT_ATTR == [100j, 200j, 300j, 400j]
         assert store2.region_specific_attr == []
         assert store2.CROSS_REGION_ATTR == []
+        assert store2.CROSS_ACCOUNT_ATTR == [100j, 200j, 300j, 400j]
         assert store3.region_specific_attr == [7, 8, 9]
         assert store3.CROSS_REGION_ATTR == [0.1, 0.2, 0.3]
+        assert store3.CROSS_ACCOUNT_ATTR == [100j, 200j, 300j, 400j]
 
+        # Ensure AccountRegionBundle reset
         sample_stores.reset()
 
+        assert store1.CROSS_ACCOUNT_ATTR == []
+        assert store2.CROSS_ACCOUNT_ATTR == []
         assert store3.region_specific_attr == []
         assert store3.CROSS_REGION_ATTR == []
+        assert store3.CROSS_ACCOUNT_ATTR == []
 
         # Ensure essential properties are retained after reset
         assert store1._region_name == eu_region
@@ -106,6 +127,19 @@ def test_store_namespacing(self, sample_stores):
             != id(backend1_ap._global)
         )
 
+        # Ensure cross-account data sharing
+        backend1_eu.CROSS_ACCOUNT_ATTR.extend([100j, 200j, 300j])
+        assert backend1_ap.CROSS_ACCOUNT_ATTR == [100j, 200j, 300j]
+        assert backend1_eu.CROSS_ACCOUNT_ATTR == [100j, 200j, 300j]
+        assert backend2_ap.CROSS_ACCOUNT_ATTR == [100j, 200j, 300j]
+        assert backend2_eu.CROSS_ACCOUNT_ATTR == [100j, 200j, 300j]
+        assert (
+            id(backend1_ap._universal)
+            == id(backend1_eu._universal)
+            == id(backend2_ap._universal)
+            == id(backend2_eu._universal)
+        )
+
     def test_valid_regions(self):
         class SampleStore(BaseStore):
             pass