-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New AWS client #7240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
New AWS client #7240
Changes from 1 commit
Commits
Show all changes
57 commits
Select commit
Hold shift + click to select a range
add7928
add mob-programming based client prototype
dfangl f57429d
WIP
viren-nadkarni ab0c79f
Merge branch 'master' into aws-client
viren-nadkarni 89e43f5
Fix imports
viren-nadkarni 247340c
Merge branch 'master' into aws-client
viren-nadkarni 0352fae
Updates
viren-nadkarni 548ced3
Fallback to default internal credentials
viren-nadkarni f6f37fa
Proper loading of default credentials
viren-nadkarni f392242
Move to its own module
viren-nadkarni f8edc9c
Fix datetime
viren-nadkarni b53e068
Allow module to be used for external clients also
viren-nadkarni f8d8d8e
Use headers for internal call arg func
viren-nadkarni 9f67ea9
Add tests
viren-nadkarni ff8e9a4
Remove dev comments
viren-nadkarni b551b2a
Default access keys
viren-nadkarni a4461c0
Fixes
viren-nadkarni 161e0ae
Merge branch 'master' into aws-client
viren-nadkarni a457707
Use separate functions for internal and external use
viren-nadkarni c0a01e1
Enhancements
viren-nadkarni 94a9170
Update tests
viren-nadkarni cc93146
Merge branch 'master' into aws-stack-dto
viren-nadkarni d616ff6
WIP
viren-nadkarni 2b2c463
Remove assertion from prod code
viren-nadkarni b6cfdea
Revamp hook logic
viren-nadkarni e39fabf
Merge branch 'master' into aws-stack-dto
viren-nadkarni 6819110
Merge branch 'aws-client' into aws-stack-dto
viren-nadkarni 70bf9f4
Merge branch 'master' into aws-client
viren-nadkarni 206f295
Fixes
viren-nadkarni cac43ed
Merge branch 'aws-client' into aws-client-dto
viren-nadkarni aeed818
Add new enricher
viren-nadkarni 0150e36
Fixes
viren-nadkarni 2dbebad
Merge branch 'aws-client' into aws-client-dto
viren-nadkarni d4c251f
Fixes
viren-nadkarni 3597fe8
Merge branch 'aws-client' into aws-client-dto
viren-nadkarni cc7a47c
Override region from target ARN
viren-nadkarni 30a4e7c
Minor touches
viren-nadkarni 2e91751
Allow no region when it is overridden
viren-nadkarni ac93d4c
Override account ID along with region for internal calls with TargetArns
viren-nadkarni d45e6ce
Remove SourceService
viren-nadkarni 8036dcf
Prevent fallback account ID for internal calls
viren-nadkarni 806f321
Update tests
viren-nadkarni 9f3f3a2
Update note
viren-nadkarni daee913
Merge branch 'master' into aws-client
viren-nadkarni 0d9ca21
Rename to ClientFactory
viren-nadkarni afaef80
Use inheritance to specialise factories
viren-nadkarni 8bdcb10
Remove internal call helper
viren-nadkarni cc693d5
Fix tests
viren-nadkarni 10b7d86
Merge branch 'master' into aws-client
viren-nadkarni
8000
Feb 15, 2023
46d690e
Merge branch 'master' into aws-client
viren-nadkarni f790be7
Merge branch 'master' into aws-client
dfangl 48cdd07
add some preliminary changes
dfangl 5d49524
add typed interface, add some tests + some test scaffolds
dfangl 4b6ff91
Merge branch 'master' into aws-client
dfangl 0641ae3
add more tests, fix internal call detection
dfangl f10f983
Apply suggestions from code review
dfangl db858a3
fix imports, remove unnecessary tests
dfangl dc7c36f
fix nits
dfangl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Apply suggestions from code review
Co-authored-by: Viren Nadkarni <viren.nadkarni@localstack.cloud>
- Loading branch information
commit f10f9830142cf5f7cecfa30ba88a53c94258c9b7
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.