8000 New AWS client by dfangl · Pull Request #7240 · localstack/localstack · GitHub
[go: up one dir, main page]

Skip to content

New AWS client #7240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 57 commits into from
Mar 13, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
add7928
add mob-programming based client prototype
dfangl Nov 24, 2022
f57429d
WIP
viren-nadkarni Jan 2, 2023
ab0c79f
Merge branch 'master' into aws-client
viren-nadkarni Jan 4, 2023
89e43f5
Fix imports
viren-nadkarni Jan 4, 2023
247340c
Merge branch 'master' into aws-client
viren-nadkarni Jan 5, 2023
0352fae
Updates
viren-nadkarni Jan 6, 2023
548ced3
Fallback to default internal credentials
viren-nadkarni Jan 12, 2023
f6f37fa
Proper loading of default credentials
viren-nadkarni Jan 12, 2023
f392242
Move to its own module
viren-nadkarni Jan 12, 2023
f8edc9c
Fix datetime
viren-nadkarni Jan 13, 2023
b53e068
Allow module to be used for external clients also
viren-nadkarni Jan 16, 2023
f8d8d8e
Use headers for internal call arg func
viren-nadkarni Jan 16, 2023
9f67ea9
Add tests
viren-nadkarni Jan 18, 2023
ff8e9a4
Remove dev comments
viren-nadkarni Jan 18, 2023
b551b2a
Default access keys
viren-nadkarni Jan 18, 2023
a4461c0
Fixes
viren-nadkarni Jan 18, 2023
161e0ae
Merge branch 'master' into aws-client
viren-nadkarni Jan 18, 2023
a457707
Use separate functions for internal and external use
viren-nadkarni Jan 18, 2023
c0a01e1
Enhancements
viren-nadkarni Jan 18, 2023
94a9170
Update tests
viren-nadkarni Jan 18, 2023
cc93146
Merge branch 'master' into aws-stack-dto
viren-nadkarni Jan 20, 2023
d616ff6
WIP
viren-nadkarni Jan 23, 2023
2b2c463
Remove assertion from prod code
viren-nadkarni Jan 30, 2023
b6cfdea
Revamp hook logic
viren-nadkarni Jan 30, 2023
e39fabf
Merge branch 'master' into aws-stack-dto
viren-nadkarni Jan 31, 2023
6819110
Merge branch 'aws-client' into aws-stack-dto
viren-nadkarni Jan 31, 2023
70bf9f4
Merge branch 'master' into aws-client
viren-nadkarni Jan 31, 2023
206f295
Fixes
viren-nadkarni Jan 31, 2023
cac43ed
Merge branch 'aws-client' into aws-client-dto
viren-nadkarni Jan 31, 2023
aeed818
Add new enricher
viren-nadkarni Jan 31, 2023
0150e36
Fixes
viren-nadkarni Jan 31, 2023
2dbebad
Merge branch 'aws-client' into aws-client-dto
viren-nadkarni Jan 31, 2023
d4c251f
Fixes
viren-nadkarni Jan 31, 2023
3597fe8
Merge branch 'aws-client' into aws-client-dto
viren-nadkarni Jan 31, 2023
cc7a47c
Override region from target ARN
viren-nadkarni Jan 31, 2023
30a4e7c
Minor touches
viren-nadkarni Jan 31, 2023
2e91751
Allow no region when it is overridden
viren-nadkarni Jan 31, 2023
ac93d4c
Override account ID along with region for internal calls with TargetArns
viren-nadkarni Jan 31, 2023
d45e6ce
Remove SourceService
viren-nadkarni Feb 1, 2023
8036dcf
Prevent fallback account ID for internal calls
viren-nadkarni Feb 1, 2023
806f321
Update tests
viren-nadkarni Feb 1, 2023
9f3f3a2
Update note
viren-nadkarni Feb 2, 2023
daee913
Merge branch 'master' into aws-client
viren-nadkarni Feb 9, 2023
0d9ca21
Rename to ClientFactory
viren-nadkarni Feb 9, 2023
afaef80
Use inheritance to specialise factories
viren-nadkarni Feb 9, 2023
8bdcb10
Remove internal call helper
viren-nadkarni Feb 9, 2023
cc693d5
Fix tests
viren-nadkarni Feb 13, 2023
10b7d86
Merge branch 'master' into aws-client
viren-nadkarni Feb 13, 2023
8000 46d690e
Merge branch 'master' into aws-client
viren-nadkarni Feb 15, 2023
f790be7
Merge branch 'master' into aws-client
dfangl Feb 27, 2023
48cdd07
add some preliminary changes
dfangl Feb 27, 2023
5d49524
add typed interface, add some tests + some test scaffolds
dfangl Mar 9, 2023
4b6ff91
Merge branch 'master' into aws-client
dfangl Mar 12, 2023
0641ae3
add more tests, fix internal call detection
dfangl Mar 13, 2023
f10f983
Apply suggestions from code review
dfangl Mar 13, 2023
db858a3
fix imports, remove unnecessary tests
dfangl Mar 13, 2023
dc7c36f
fix nits
dfangl Mar 13, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review
Co-authored-by: Viren Nadkarni <viren.nadkarni@localstack.cloud>
  • Loading branch information
dfangl and viren-nadkarni authored Mar 13, 2023
commit f10f9830142cf5f7cecfa30ba88a53c94258c9b7
2 changes: 1 addition & 1 deletion localstack/aws/accounts.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def set_aws_account_id(account_id: str) -> None:
REQUEST_CTX_TLS.account_id = account_id


def get_account_id_from_access_key_id(access_key_id: str) -> Optional[str]:
def get_account_id_from_access_key_id(access_key_id: str) -> str:
"""Return the Account ID associated the Access Key ID."""

# If AWS_ACCESS_KEY_ID has a 12-digit integer value, use it as the account ID
Expand Down
2 changes: 1 addition & 1 deletion localstack/aws/handlers/internal_requests.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class InternalRequestParamsEnricher(Handler):
def __call__(self, chain: HandlerChain, context: RequestContext, response: Response):
if header := context.request.headers.get(INTERNAL_REQUEST_PARAMS_HEADER):
try:
dto = load_dto(header)
dto = MappingProxyType(load_dto(header))
except Exception as e:
LOG.error("Error loading request parameters '%s', Error: %s", header, e)
return
Expand Down
0