10000 Extend valid regions for Stores to include extended AWS partitions by whummer · Pull Request #6745 · localstack/localstack · GitHub
[go: up one dir, main page]

Skip to content

Extend valid regions for Stores to include extended AWS partitions #6745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

whummer
Copy link
Member
@whummer whummer commented Aug 24, 2022

Extend valid regions for Stores to include extended AWS partitions. Currently, store creation fails when creating them for a region within one of the extended AWS partitions, e.g., us-gov-west-1

@whummer whummer requested a review from viren-nadkarni August 24, 2022 13:20
@whummer whummer temporarily deployed to localstack-ext-tests August 24, 2022 13:20 Inactive
@giograno
Copy link
Member

Chiming in. Came across a similar issue while migrating Cognito (see https://github.com/localstack/localstack-ext/blob/f6e79b0e458d53fa57a1da01b9be6e3c5e9a536f/localstack_ext/services/cognito_idp/models.py#L289-L296).

Copy link
Member
@viren-nadkarni viren-nadkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch! 🎉

@whummer whummer merged commit 4a8d6af into master Aug 24, 2022
@whummer whummer deleted the stores-valid-regions branch August 24, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0