Kinesis: SubscribeToShard session cut after 5min #6732
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
There was a problem hiding this comment.
Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining our Slack Community and share your PR on the #community channel to share your contributions with us. Please make sure you are following our contributing guidelines and our Code of Conduct.
|
I have read the CLA Document and I hereby sign the CLA |
48d8c31 to
c7e1bbb
Compare
c7e1bbb to
3b1e979
Compare
There was a problem hiding this comment.
Great set of changes!
The stream timeout is now properly implemented, and you AWS validated a lot of tests! 🔝
I only posted a few questions and nitpicks.
If you want to go the extra mile you could try migrating them to snapshot tests too. 🙂
Once the PR is merged, I will migrate the fix to the upcoming ASF migration in #6166.
0be8d7a to
6aea352
Compare
…, adds a test for it
…s tests, reduced patched timeout from PR comments
6aea352 to
670c5cb
Compare
Summary
Fixes an issue where a SubscribeToShard is cut too early - now set to 5min.
Additionally added aws validated test marks and a basic kinesis stream tags test.
Test
test_subscribe_to_shard_timeout
Related
Fixes: #5830