Allow conditional skip with skip_snapshot_verify #6731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steffyP
approved these changes
Aug 23, 2022
dfangl
reviewed
Aug 23, 2022
Co-authored-by: Daniel Fangl <daniel.fangl@localstack.cloud>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example usage:
@pytest.mark.skip_snapshot_verify(condition=lambda: 1 == 1)The condition always needs to be a callable that will be evaluated to determine if the verification should be skipped or not.
This PR also makes sure that verification of snapshots is never skipped when running with
TEST_TARGET=AWS_CLOUD.