8000 fix error in deleting lambda configuration keys by dfangl · Pull Request #6627 · localstack/localstack · GitHub
[go: up one dir, main page]

Skip to content

fix error in deleting lambda configuration keys #6627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

dfangl
Copy link
Member
@dfangl dfangl commented Aug 9, 2022

Addresses #6464

When using only community code, but setting the package type to image (which should work until it comes to invocation), the "Layer" key is not available in the "Configuration" dict, when running get-function.
This leads to a 500 error when running get-function.

This PR fixes this by using pop instead of del, which will not error on missing Keys.

@dfangl dfangl requested a review from dominikschubert as a code owner August 9, 2022 13:20
@dfangl dfangl temporarily deployed to localstack-ext-tests August 9, 2022 13:21 Inactive
@github-actions
Copy link
github-actions bot commented Aug 9, 2022

LocalStack integration with Pro

       3 files  ±0         3 suites  ±0   1h 6m 55s ⏱️ - 1m 39s
1 177 tests ±0  1 135 ✔️ ±0  42 💤 ±0  0 ±0 
1 542 runs  ±0  1 469 ✔️ ±0  73 💤 ±0  0 ±0 

Results for commit f81a492. ± Comparison against base commit 3f7a7fe.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 91.623% when pulling f81a492 on fix-image-get-function into 3f7a7fe on master.

Copy link
Member
@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

@dfangl dfangl merged commit f038cae into master Aug 10, 2022
@dfangl dfangl deleted the fix-image-get-function branch August 10, 2022 12:03
@localstack localstack locked and limited conversation to collaborators Aug 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0