refactor sns tests and fifo topic validations #6586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thrau
approved these changes
Aug 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first PR to extend with complete snapshot validation of all AWS validated tests.
31/43 tests are AWS validated (1 more coming with snapshots)
10 are only Localstack (related to SMS and http endpoints)
1 is skipped
Some validation was added, especially concerning FIFO topics. The behaviour is not implemented (it differs a bit from SQS, and is managed at the topic level), there is no feature request for it yet.
Added a
call_motocall to theunsubscribeoperation, it would make Moto not synced concerning subscriptions with our own backend