8000 fix ASF / botocore CBOR decoding by alexrashed · Pull Request #6494 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

fix ASF / botocore CBOR decoding #6494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2022
Merged

fix ASF / botocore CBOR decoding #6494

merged 1 commit into from
Jul 21, 2022

Conversation

alexrashed
Copy link
Member

This PR addresses the handling of CBOR encoded messages.
It contains two fixes:

  • ASF's BaseJSONRequestParser: Proper binary decoding for CBOR (since the binary data is not base64 encoded).
  • botocore: Adds support for basic CBOR decoding to botocore (which doesn't support CBOR at all).
    • When using the botocore parser (in client.py) we configure the JSON parser to properly handle CBOR datetime and blobs.

Fixes #6492

@alexrashed alexrashed requested a review from thrau as a code owner July 21, 2022 11:14
@alexrashed alexrashed temporarily deployed to localstack-ext-tests July 21, 2022 11:14 Inactive
@alexrashed alexrashed force-pushed the fix-asf-cbor-parsing branch from 7fc4d3b to c2f1e37 Compare July 21, 2022 11:28
@alexrashed alexrashed temporarily deployed to localstack-ext-tests July 21, 2022 11:29 Inactive
@alexrashed alexrashed force-pushed the fix-asf-cbor-parsing branch from c2f1e37 to 0e0e6ff Compare July 21, 2022 11:49
@alexrashed alexrashed temporarily deployed to localstack-ext-tests July 21, 2022 11:49 Inactive
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 91.597% when pulling 0e0e6ff on fix-asf-cbor-parsing into e105e48 on master.

@github-actions
Copy link

LocalStack integration with Pro

       3 files         3 suites   1h 6m 44s ⏱️
1 129 tests 1 088 ✔️ 41 💤 0 ❌
1 446 runs  1 376 ✔️ 70 💤 0 ❌

Results for commit 0e0e6ff.

thrau
thrau approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member
@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! looking forward to get kinesis migrated now 😁

@thrau thrau merged commit 750d387 into master Jul 21, 2022
@thrau thrau deleted the fix-asf-cbor-parsing branch July 21, 2022 16:00
@localstack localstack locked and limited conversation to collaborators Jul 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thrau thrau thrau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Certain records cause localstack.aws.protocol.parser.ProtocolParserError but work as expected with production AWS Kinesis
3 participants
@alexrashed @coveralls @thrau
0