8000 migrate Kinesis to ASF by alexrashed · Pull Request #6166 · localstack/localstack · GitHub
[go: up one dir, main page]

Skip to content

migrate Kinesis to ASF #6166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Aug 30, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove Logs AwsApiListener extension
  • Loading branch information
alexrashed committed Aug 30, 2022
commit 1c06be6d583d82dbd3c0ea1ffb4f37f32334c9e2
21 changes: 1 addition & 20 deletions localstack/services/logs/provider.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,7 @@
PutLogEventsResponse,
SequenceToken,
)
from localstack.aws.proxy import AwsApiListener
from localstack.constants import APPLICATION_AMZ_JSON_1_1
from localstack.services.messages import Request, Response
from localstack.services.moto import MotoFallbackDispatcher, call_moto
from localstack.services.moto import call_moto
from localstack.services.plugins import ServiceLifecycleHook
from localstack.utils.aws import aws_stack
from localstack.utils.common import is_number
Expand Down Expand Up @@ -75,22 +72,6 @@ def put_log_events(
return call_moto(context)


class LogsAwsApiListener(AwsApiListener):
def __init__(self):
self.provider = self._create_provider()
super().__init__("logs", MotoFallbackDispatcher(self.provider))

def _create_provider(self):
return LogsProvider()

def request(self, request: Request) -> Response:
response = super().request(request)
# Fix Incorrect response content-type header from cloudwatch logs #1343.
# True for all logs api responses.
response.headers["content-type"] = APPLICATION_AMZ_JSON_1_1
return response


def get_pattern_matcher(pattern: str) -> Callable[[str, Dict], bool]:
"""Returns a pattern matcher. Can be patched by plugins to return a more sophisticated pattern matcher."""
return lambda _pattern, _log_event: True
Expand Down
5 changes: 3 additions & 2 deletions localstack/services/providers.py
Original file line number Diff line number Diff line change
Expand Up @@ -211,9 +211,10 @@ def awslambda_asf():

@aws_provider()
def logs():
from localstack.services.logs.provider import LogsAwsApiListener
from localstack.services.logs.provider import LogsProvider

listener = LogsAwsApiListener()
provider = LogsProvider()
listener = AwsApiListener("logs", MotoFallbackDispatcher(provider))
return Service("logs", listener=listener)


Expand Down
0