8000 fix dependencies installation for dev release publish by bentsku · Pull Request #12726 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

fix dependencies installation for dev release publish #12726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2025
Merged

fix dependencies installation for dev release publish #12726

merged 1 commit into from
Jun 6, 2025

Conversation

bentsku
Copy link
Contributor
@bentsku bentsku commented Jun 6, 2025 •
edited
Loading

Motivation

Follow up from #12725, we were using make install-basic before building the entrypoints, which lead to issue while building, short snippet:

running plugins
error importing module localstack.aws.api.sts: No module named 'botocore'
error importing module localstack.services.opensearch.resource_providers.aws_elasticsearch_domain: No module named 'botocore'
error importing module localstack.aws.api.core: No module named 'botocore'
error importing module localstack.services.stepfunctions.asl.component.state.state_choice.comparison.comparison: No module named 'antlr4'
error importing module localstack.services.opensearch.cluster: No module named 'werkzeug'
error importing module localstack.services.sqs.exceptions: No module named 'botocore'

Failing run: https://github.com/localstack/localstack/actions/runs/15494460312/job/43628963451

By using install-runtime, we'll make sure we have the right dependencies before building the entry points

Changes

  • switch the make target before publishing

Testing

Trying setting up a new virtual environment and run make install-basic entrypoints and see the failures, then try with make install-runtime entrypoints.

@bentsku bentsku added this to the 4.6 milestone Jun 6, 2025
@bentsku bentsku self-assigned this Jun 6, 2025
@bentsku bentsku added area: ci Running LocalStack in CI environments semver: patch Non-breaking changes which can be included in patch releases labels Jun 6, 2025
@bentsku bentsku requested a review from cloutierMat June 6, 2025 20:50
@github-actions GitHub Actions
Copy link
github-actions bot commented Jun 6, 2025

Test Results - Preflight, Unit

21 595 tests  ±0   19 940 ✅ ±0   6m 10s ⏱️ -12s
     1 suites ±0    1 655 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 7a57fc3. ± Comparison against base commit 36f5b6d.

cloutierMat
cloutierMat approved these changes Jun 6, 2025
View reviewed changes
Copy link
Contributor
@cloutierMat cloutierMat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Thank you for the deep dive, debug and super quick fix! 🎉

@bentsku bentsku merged commit ed6c94a into master Jun 6, 2025
26 of 33 checks passed
@bentsku bentsku deleted the fix-dev-release branch June 6, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloutierMat cloutierMat cloutierMat approved these changes

@alexrashed alexrashed Awaiting requested review from alexrashed alexrashed is a code owner

@dfangl dfangl Awaiting requested review from dfangl dfangl is a code owner

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

@silv-io silv-io Awaiting requested review from silv-io silv-io is a code owner

@k-a-il k-a-il Awaiting requested review from k-a-il k-a-il is a code owner

Assignees

@bentsku bentsku

Labels
area: ci Running LocalStack in CI environments semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
4.6
Development

Successfully merging this pull request may close these issues.
2 participants
@bentsku @cloutierMat
0