Fix publishing credentials #12723
Merged
Fix publishing credentials #12723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-a-il
approved these changes
Jun 6, 2025
fa438a4 to
93155bb
Compare
Test Results - Preflight, Unit21 595 tests ±0 19 940 ✅ ±0 6m 33s ⏱️ +20s Results for commit fa438a43. ± Comparison against base commit c22632d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The DockerHub user secrets were wrongly assumed to contain
PUSHin them, compared to thePULLtokens. However, a look at the s3 image pipeline shows that this is not the case.Also, the twine credentials are missing in the dev release publishing step.
Changes