8000 GH Actions:change test selection parameter by k-a-il · Pull Request #12710 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

GH Actions:change test selection parameter #12710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 5, 2025
Merged

GH Actions:change test selection parameter #12710

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0f04908
GH Actions:change test selection parameter
k-a-il Jun 4, 2025
fa497bd
GH Actions:enable test selection
k-a-il Jun 4, 2025
6d442f3
GH Actions: enable tets selection
k-a-il Jun 4, 2025
4716c66
GH Actions: run test with test selection on pull-request events
k-a-il Jun 4, 2025
36513bb
Gh ACtions: test selection condition
k-a-il Jun 4, 2025
28b4432
GH Actions: test selection
k-a-il Jun 4, 2025
472ffcb
Revert "GH Actions: test selection"
k-a-il Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/aws-main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ jobs:
# default "disableCaching" to `false` if it's a push or schedule event
disableCaching: ${{ inputs.disableCaching == true }}
# default "disableTestSelection" to `true` if it's a push or schedule event
disableTestSelection: ${{ inputs.enableTestSelection != true }}
disableTestSelection: ${{ (inputs.enableTestSelection != '' && inputs.enableTestSelection) || github.event_name == 'push' }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inputs.enableTestSelection will be an empty string if the workflow is triggered automatically. I think this deifinition version (inputs.enableTestSelection != '' && inputs.enableTestSelection) makes our intentions clearer: use the input value if it's defined, or use the push event as a fallback.

PYTEST_LOGLEVEL: ${{ inputs.PYTEST_LOGLEVEL }}
secrets:
DOCKERHUB_PULL_USERNAME: ${{ secrets.DOCKERHUB_PULL_USERNAME }}
Expand Down
Loading
0