10000 Move publishing of images and coverage from CircleCI to GHA by silv-io · Pull Request #12708 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

Move publishing of images and coverage from CircleCI to GHA #12708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 6, 2025
Merged

Move publishing of images and coverage from CircleCI to GHA #12708

merged 2 commits into from
Jun 6, 2025

Conversation

silv-io
Copy link
Member
@silv-io silv-io commented Jun 4, 2025 •
edited
Loading

Motivation

This is the penultimate PR in the initiative to move from CircleCI to GitHub Actions.
It moves the pushing of images and coverage reports. After merging this, we can disable the triggers for the CircleCI pipeline and, if everything goes fine, remove it at the end

Changes

  • Push Images in GitHub Actions Pipeline instead of CircleCI
  • Push Coverage reports in GitHub Actions Pipeline instead of CircleCI

Testing

Both image and coverage push were tested at the time of introduction

TODO

What's left to do:

  • Deactivate triggers for CircleCI pipeline
  • ...

@silv-io silv-io requested a review from k-a-il June 4, 2025 07:00
@silv-io silv-io added this to the 4.6 milestone Jun 4, 2025
@silv-io silv-io added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Jun 4, 2025
@github-actions GitHub Actions
Copy link
github-actions bot commented Jun 4, 2025 •
edited
Loading

Test Results - Preflight, Unit

21 595 tests  ±0   19 940 ✅ ±0   6m 16s ⏱️ -3s
     1 suites ±0    1 655 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit c8388cd. ± Comparison against base commit 6a52793.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
github-actions bot commented Jun 4, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 13s ⏱️ +6s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit c8388cd. ± Comparison against base commit 6a52793.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
github-actions bot commented Jun 4, 2025 •
edited
Loading

@github-actions GitHub Actions
Copy link
github-actions bot commented Jun 4, 2025 •
edited
Loading

Test Results - Alternative Providers

987 tests   569 ✅  22m 19s ⏱️
  4 suites  418 💤
  4 files      0 ❌

Results for commit c8388cd.

♻️ This comment has been updated with latest results.

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 21m 40s ⏱️
5 228 tests 4 299 ✅ 929 💤 0 ❌
5 234 runs  4 299 ✅ 935 💤 0 ❌

Results for commit c8388cd.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
github-actions bot commented Jun 4, 2025 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 43m 31s ⏱️ - 1m 37s
4 871 tests ±0  4 094 ✅ ±0  777 💤 ±0  0 ❌ ±0 
4 873 runs  ±0  4 094 ✅ ±0  779 💤 ±0  0 ❌ ±0 

Results for commit c8388cd. ± Comparison against base commit 6a52793.

♻️ This comment has been updated with latest results.

@k-a-il
Copy link
Contributor
k-a-il commented Jun 6, 2025

I think you forgot to remove one of TO-DOs for coverall 🤔

@silv-io silv-io force-pushed the finalize-gha-switch branch from 9c8bde8 to 8237d9f Compare June 6, 2025 09:48
@silv-io
Copy link
Member Author
silv-io commented Jun 6, 2025 •
edited
Loading

I think you forgot to remove one of TO-DOs for coverall 🤔

Thanks :) Missed it because I only searched for TODO and not TO-DO :P

@silv-io silv-io changed the title Remove CircleCI pipeline, set GitHub Actions as default Move publishing of images and coverage from CircleCI to GHA Jun 6, 2025
@silv-io silv-io marked this pull request as ready for review June 6, 2025 09:55
k-a-il
k-a-il approved these changes Jun 6, 2025
View reviewed changes
Copy link
Contributor
@k-a-il k-a-il left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 🎉

@silv-io silv-io merged commit 2f1fe48 into master Jun 6, 2025
60 checks passed
@silv-io silv-io deleted the finalize-gha-switch branch June 6, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-a-il k-a-il k-a-il approved these changes

Assignees
No one assigned
Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
4.6
Development

Successfully merging this pull request may close these issues.
2 participants
@silv-io @k-a-il
0