8000 GH Actions: fix order of path filters for push and pull-request events by k-a-il · Pull Request #12686 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

GH Actions: fix order of path filters for push and pull-request events #12686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 29, 2025
Merged

GH Actions: fix order of path filters for push and pull-request events #12686

merged 3 commits into from
May 29, 2025

Conversation

k-a-il
Copy link
Contributor
@k-a-il k-a-il commented May 29, 2025 •
edited
Loading

Motivation

Thanks to this PR, it was discovered that the order of path filters for push and pull_request triggers was incorrect. As a result, the aws-main.yml workflow was not triggered when aws-tests.yml was updated in the PR.

Changes

  • Fix path ordering not to trigger a workflow for all .github files except files in the actions folder, aws_main.yml, and aws_tests.yml

@k-a-il k-a-il self-assigned this May 29, 2025
@k-a-il k-a-il added the semver: patch Non-breaking changes which can be included in patch releases label May 29, 2025
@k-a-il k-a-il added this to the 4.5 milestone May 29, 2025
@k-a-il k-a-il requested a review from simonrw May 29, 2025 10:42
@github-actions GitHub Actions
Copy link

Test Results - Preflight, Unit

21 579 tests  ±0   19 927 ✅ ±0   6m 19s ⏱️ +5s
     1 suites ±0    1 652 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 6a37fea. ± Comparison against base commit 79b46be.

@simonrw
Copy link
Contributor
simonrw commented May 29, 2025

This seems like a very strange fix for this error. Could you explain more how the old evaluation logic worked, and how this change fixes it?

@github-actions GitHub Actions
Copy link

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 11s ⏱️ +2s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 6a37fea. ± Comparison against base commit 79b46be.

@github-actions GitHub Actions
Copy link

Test Results - Alternative Providers

597 tests   420 ✅  14m 56s ⏱️
  4 suites  177 💤
  4 files      0 ❌

Results for commit 6a37fea.

@k-a-il
Copy link
Contributor Author
k-a-il commented May 29, 2025 •
edited
Loading

This seems like a very strange fix for this error. Could you explain more how the old evaluation logic worked, and how this change fixes it?

@simonrw Yes, indeed. The problem is that order of path patterns matter and it was applied in the incorrect order. Now, we firstly exclude all files in the .github folder and after that include only some we are interested in, such as aws_main.yml. Reference to GH docs.

@github-actions GitHub Actions
Copy link

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 22m 19s ⏱️
4 824 tests 4 282 ✅ 542 💤 0 ❌
4 830 runs  4 282 ✅ 548 💤 0 ❌

Results for commit 6a37fea.

@k-a-il k-a-il merged commit e1db42e into master May 29, 2025
46 checks passed
@k-a-il k-a-il deleted the gh-actions-fix-wf-paths-trigger branch May 29, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonrw simonrw simonrw approved these changes

@alexrashed alexrashed Awaiting requested review from alexrashed alexrashed is a code owner

@dfangl dfangl Awaiting requested review from dfangl dfangl is a code owner

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

@silv-io silv-io Awaiting requested review from silv-io silv-io is a code owner

Assignees

@k-a-il k-a-il

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
4.5
Development

Successfully merging this pull request may close these issues.
2 participants
@k-a-il @simonrw
0