-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
CircleCI to GH Actions:updated docs references to GH Actions #12666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just some minor suggestions around the naming of GitHub Actions
, pre-existing typos and a question
Co-authored-by: Silvio Vasiljevic <silvio.vasiljevic@gmail.com>
Co-authored-by: Silvio Vasiljevic <silvio.vasiljevic@gmail.com>
Co-authored-by: Silvio Vasiljevic <silvio.vasiljevic@gmail.com>
Co-authored-by: Silvio Vasiljevic <silvio.vasiljevic@gmail.com>
Test Results (amd64) - Integration, Bootstrap 5 files ±0 5 suites ±0 2h 23m 55s ⏱️ + 1m 5s For more details on these failures, see this check. Results for commit 08bcdea. ± Comparison against base commit 433aeff. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 🚀 Just a minor suggestion, rest LGTM 🎉
1. Set **Name** to `randomize-aws-credentials` | ||
1. Set **Value** to `true` | ||
1. Click the **Trigger Pipeline** button to commence the workflow. | ||
We regularly run the test suite on GitHub Actions to verify compatibility with multi-account and multi-region features. A [scheduled GitHub Actions workflow](https://github.com/localstack/localstack/actions/workflows/aws-tests-mamr.yml) runs on working days at 01:00 UTC, executing the tests with randomized account IDs and regions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: To improve readability and scanning, I would suggest breaking the paragraph into two lines:
We regularly run the test suite on GitHub Actions to verify compatibility with multi-account and multi-region features.
A [scheduled GitHub Actions workflow](https://github.com/localstack/localstack/actions/workflows/aws-tests-mamr.yml) runs on working days at 01:00 UTC, executing the tests with randomized account IDs and regions.
Motivation
This PR is part of the initiative to migrate from CircleCI to GitHub Actions. It updates the documentation to reflect this change by replacing references to CircleCI with GitHub Actions.
Changes
README
docs