8000 CircleCI to GH Actions:updated docs references to GH Actions by k-a-il · Pull Request #12666 · localstack/localstack · GitHub
[go: up one dir, main page]

Skip to content

CircleCI to GH Actions:updated docs references to GH Actions #12666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

k-a-il
Copy link
Contributor
8000
@k-a-il k-a-il commented May 27, 2025

Motivation

This PR is part of the initiative to migrate from CircleCI to GitHub Actions. It updates the documentation to reflect this change by replacing references to CircleCI with GitHub Actions.

Changes

  • Updated README docs
  • Updated badges

@k-a-il k-a-il self-assigned this May 27, 2025
@k-a-il k-a-il added the semver: patch Non-breaking changes which can be included in patch releases label May 27, 2025
@k-a-il k-a-il requested review from silv-io and sannya-singal May 27, 2025 11:27
@k-a-il k-a-il marked this pull request as ready for review May 27, 2025 11:32
@k-a-il k-a-il requested review from HarshCasper and thrau as code owners May 27, 2025 11:32
@k-a-il k-a-il removed the request for review from HarshCasper May 27, 2025 11:32
@k-a-il k-a-il changed the title CircleCI to GH Actions:updated docs CircleCI to GH Actions:updated docs references from CircleCI to GH Actions May 27, 2025
@k-a-il k-a-il changed the title CircleCI to GH Actions:updated docs references from CircleCI to GH Actions CircleCI to GH Actions:updated docs references to GH Actions May 27, 2025
Copy link
github-actions bot commented May 27, 2025

Test Results - Preflight, Unit

21 579 tests  ±0   19 927 ✅ ±0   6m 6s ⏱️ -10s
     1 suites ±0    1 652 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 08bcdea. ± Comparison against base commit 433aeff.

♻️ This comment has been updated with latest results.

Copy link
Member
@silv-io silv-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just some minor suggestions around the naming of GitHub Actions, pre-existing typos and a question

k-a-il and others added 4 commits May 27, 2025 13:41
Co-authored-by: Silvio Vasiljevic <silvio.vasiljevic@gmail.com>
Co-authored-by: Silvio Vasiljevic <silvio.vasiljevic@gmail.com>
Co-authored-by: Silvio Vasiljevic <silvio.vasiljevic@gmail.com>
Co-authored-by: Silvio Vasiljevic <silvio.vasiljevic@gmail.com>
Copy link
github-actions bot commented May 27, 2025

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 5s ⏱️ -2s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 08bcdea. ± Comparison against base commit 433aeff.

♻️ This comment has been updated with latest results.

Copy link
github-actions bot commented May 27, 2025

Test Results - Alternative Providers

597 tests  ±0   420 ✅ ±0   14m 3s ⏱️ -49s
  4 suites ±0   177 💤 ±0 
  4 files   ±0     0 ❌ ±0 

Results for commit 08bcdea. ± Comparison against base commit 433aeff.

♻️ This comment has been updated with latest results.

Copy link
github-actions bot commented May 27, 2025

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 45m 4s ⏱️ -20s
4 468 tests ±0  4 080 ✅ ±0  388 💤 ±0  0 ❌ ±0 
4 470 runs  ±0  4 080 ✅ ±0  390 💤 ±0  0 ❌ ±0 

Results for commit 08bcdea. ± Comparison against base commit 433aeff.

♻️ This comment has been updated with latest results.

Copy link
github-actions bot commented May 27, 2025

Test Results (amd64) - Integration, Bootstrap

    5 files  ±0      5 suites  ±0   2h 23m 55s ⏱️ + 1m 5s
4 823 tests ±0  4 281 ✅  - 1  541 💤 ±0  1 ❌ +1 
4 829 runs  ±0  4 281 ✅  - 1  547 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 08bcdea. ± Comparison against base commit 433aeff.

♻️ This comment has been updated with latest results.

Copy link
Contributor
@sannya-singal sannya-singal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🚀 Just a minor suggestion, rest LGTM 🎉

1. Set **Name** to `randomize-aws-credentials`
1. Set **Value** to `true`
1. Click the **Trigger Pipeline** button to commence the workflow.
We regularly run the test suite on GitHub Actions to verify compatibility with multi-account and multi-region features. A [scheduled GitHub Actions workflow](https://github.com/localstack/localstack/actions/workflows/aws-tests-mamr.yml) runs on working days at 01:00 UTC, executing the tests with randomized account IDs and regions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: To improve readability and scanning, I would suggest breaking the paragraph into two lines:

We regularly run the test suite on GitHub Actions to verify compatibility with multi-account and multi-region features. 
A [scheduled GitHub Actions workflow](https://github.com/localstack/localstack/actions/workflows/aws-tests-mamr.yml) runs on working days at 01:00 UTC, executing the tests with randomized account IDs and regions.

@k-a-il k-a-il added this to the 4.5 milestone May 29, 2025
@tiurin tiurin modified the milestones: 4.5, 4.6 Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0