8000 CloudFormation v2 Engine: Base Support for Fn::Transform by MEPalma · Pull Request #12662 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

CloudFormation v2 Engine: Base Support for Fn::Transform #12662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 2, 2025
Merged

CloudFormation v2 Engine: Base Support for Fn::Transform #12662

merged 9 commits into from
Jun 2, 2025

Conversation

MEPalma
Copy link
Contributor
@MEPalma MEPalma commented May 26, 2025

* Extends #12660

Motivation

The introduction of the CloudFormation v2 engine laid the foundation for a redesigned engine capable of accurately determining update requirements between CloudFormation deployments, while also enabling parallel execution during updates. However, the current implementation offers no support for Fn::Transform.

Changes

  • Add base support for Fn::Transform
  • Port v1 tests for Fn::Transform

@MEPalma MEPalma added this to the 4.5 milestone May 26, 2025
@MEPalma MEPalma self-assigned this May 26, 2025
@MEPalma MEPalma added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label May 26, 2025
@MEPalma MEPalma removed request for simonrw and pinzon May 26, 2025 15:03
@github-actions GitHub Actions
Copy link
github-actions bot commented May 26, 2025 •
edited
Loading

Test Results - Preflight, Unit

21 579 tests  ±0   19 927 ✅ ±0   6m 12s ⏱️ ±0s
     1 suites ±0    1 652 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 4ce5b8f. ± Comparison against base commit 7656937.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
github-actions bot commented May 26, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 6s ⏱️ -2s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 4ce5b8f. ± Comparison against base commit 7656937.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
github-actions bot commented May 26, 2025 •
edited
Loading

Test Results - Alternative Providers

971 tests   532 ✅  21m 26s ⏱️
  4 suites  439 💤
  4 files      0 ❌

Results for commit 4ce5b8f.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
github-actions bot commented May 26, 2025 •
edited
Loading

LocalStack Community integration with Pro

  2 files    2 suites   21m 42s ⏱️
870 tests 320 ✅ 550 💤 0 ❌
872 runs  320 ✅ 552 💤 0 ❌

Results for commit 4ce5b8f.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
github-actions bot commented May 26, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 21m 13s ⏱️
5 198 tests 4 286 ✅ 912 💤 0 ❌
5 204 runs  4 286 ✅ 918 💤 0 ❌

Results for commit 4ce5b8f.

♻️ This comment has been updated with latest results.

@MEPalma MEPalma mentioned this pull request May 27, 2025
Merged
@MEPalma MEPalma requested review from simonrw and removed request for dominikschubert May 27, 2025 16:49
@MEPalma MEPalma changed the base branch from master to MEP-CFN-v1_test_port May 28, 2025 09:28
simonrw
simonrw approved these changes May 29, 2025
View reviewed changes
Copy link
Contributor
@simonrw simonrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment about validations, if we are not going to revalidate then we should at least copy the snapshot/validation files correctly

tests/aws/services/cloudformation/v2/ported_from_v1/engine/test_mappings.py Outdated
@@ -249,6 +249,7 @@ def test_mapping_ref_map_key(self, deploy_cfn_template, aws_client, map_key, sho

aws_client.sns.get_topic_attributes(TopicArn=topic_arn)

# @pytest.mark.skip(reason="CFNV2:Mappings")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# @pytest.mark.skip(reason="CFNV2:Mappings")

tests/aws/services/cloudformation/v2/ported_from_v1/test_template_engine.validation.json Outdated
@@ -0,0 +1,107 @@
{
"tests/aws/services/cloudformation/test_template_engine.py::TestImportValues::test_cfn_with_exports": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you just copy the validations over? These paths are wrong. I see the snapshots have not been updated as well. I don't mind not revalidating (though it would be nice!) but they should at least be consistent so revalidating in the future will change rather than add new validation items.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, indeed these should be ported like in #12660

Base automatically changed from MEP-CFN-v1_test_port to master June 2, 2025 09:51
@MEPalma MEPalma merged 7E70 commit 2c2c7bf into master Jun 2, 2025
57 checks passed
@MEPalma MEPalma deleted the MEP-CFN-fn_transform branch June 2, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonrw simonrw simonrw approved these changes

Assignees

@MEPalma MEPalma

Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
4.5
Development

Successfully merging this pull request may close these issues.
2 participants
@MEPalma @simonrw
0