-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
CloudFormation v2 Engine: Base Support for Fn::Transform #12662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Results - Alternative Providers971 tests 532 ✅ 21m 26s ⏱️ Results for commit 4ce5b8f. ♻️ This comment has been updated with latest results. |
LocalStack Community integration with Pro 2 files 2 suites 21m 42s ⏱️ Results for commit 4ce5b8f. ♻️ This comment has been updated with latest results. |
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 2h 21m 13s ⏱️ Results for commit 4ce5b8f. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a comment about validations, if we are not going to revalidate then we should at least copy the snapshot/validation files correctly
@@ -249,6 +249,7 @@ def test_mapping_ref_map_key(self, deploy_cfn_template, aws_client, map_key, sho | |||
|
|||
aws_client.sns.get_topic_attributes(TopicArn=topic_arn) | |||
|
|||
# @pytest.mark.skip(reason="CFNV2:Mappings") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# @pytest.mark.skip(reason="CFNV2:Mappings") |
@@ -0,0 +1,107 @@ | |||
{ | |||
"tests/aws/services/cloudformation/test_template_engine.py::TestImportValues::test_cfn_with_exports": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you just copy the validations over? These paths are wrong. I see the snapshots have not been updated as well. I don't mind not revalidating (though it would be nice!) but they should at least be consistent so revalidating in the future will change rather than add new validation items.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, indeed these should be ported like in #12660
* Extends #12660
Motivation
The introduction of the CloudFormation v2 engine laid the foundation for a redesigned engine capable of accurately determining update requirements between CloudFormation deployments, while also enabling parallel execution during updates. However, the current implementation offers no support for
Fn::Transform
.Changes
Fn::Transform
Fn::Transform