8000 GithubActions: skip tinybird, docker push and docker login in forks by k-a-il · Pull Request #12639 · localstack/localstack · GitHub
[go: up one dir, main page]

Skip to content

GithubActions: skip tinybird, docker push and docker login in forks #12639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025

Conversation

k-a-il
Copy link
Contributor
@k-a-il k-a-il commented May 19, 2025

Motivation

This PR introduces conditions to GitHub Actions steps and jobs to skip Docker login, Docker push, and pushing to Tinybird for forked repositories outside the LocalStack organization. This will allow contributors to run tests in forked repositories without needing to define secrets or modifying the testing workflows.

Changes

  • Check that repository is localstack/localstack in docker and tinybird push steps, if not - skip these steps.
  • Check that organization owner is localstack in docker pull steps, if not - skip these steps. Checking organization owner because we plan to re-use aws-tests.yml workflow in another LocalStack repository in the future.

Testing

@k-a-il k-a-il self-assigned this May 19, 2025
@k-a-il k-a-il added the semver: patch Non-breaking changes which can be included in patch releases label May 19, 2025
@k-a-il k-a-il requested a review from silv-io May 19, 2025 15:17
@k-a-il k-a-il marked this pull request as ready for review May 19, 2025 15:17
@k-a-il k-a-il removed the request for review from dfangl May 19, 2025 15:20
Copy link
Member
@silv-io silv-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Makes sense to skip these in forks 👍🏼

@k-a-il k-a-il merged commit 4de49e9 into master May 20, 2025
46 of 47 checks passed
@k-a-il k-a-il deleted the circleci-to-gh-skip-in-forks branch May 20, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0