8000 CFn v2: better handle deploy errors by simonrw · Pull Request #12601 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

CFn v2: better handle deploy errors #12601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2025
Merged

CFn v2: better handle deploy errors #12601

merged 1 commit into from
May 12, 2025

Conversation

simonrw
Copy link
Contributor
@simonrw simonrw commented May 9, 2025

Motivation

Currently when a deploy error occurs, the stack does not get put into an error state, so the deploy process loops until it times out. If an exception occurs during the deploy process we should stop the deployment ASAP and mark it as failed so that our development and investigation can continue quicker, and this better reflects AWS state.

Changes

Catch an exception from the deploy process and mark the stack as failed.

Testing

Uncomment a skipped test from the tests/aws/services/cloudformation/v2 directory that fails during deployment time, and marvel at how quickly an error is thrown, whereas before it would take the wait time of the stack deployment to fail.

@simonrw simonrw added aws:cloudformation AWS CloudFormation semver: patch Non-breaking changes which can be included in patch releases labels May 9, 2025
@github-actions GitHub Actions
Copy link
github-actions bot commented May 9, 2025 •
edited
Loading

LocalStack Community integration with Pro

  2 files  ±    0    2 suites  ±0   21m 8s ⏱️ - 1h 21m 53s
490 tests  - 3 935  315 ✅  - 3 727  175 💤  - 208  0 ❌ ±0 
492 runs   - 3 935  315 ✅  - 3 727  177 💤  - 208  0 ❌ ±0 

Results for commit aa74baa. ± Comparison against base commit e7383de.

This pull request removes 3935 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

♻️ This comment has been updated with latest results.

@simonrw simonrw force-pushed the cfn/v2/deploy-error-handling branch from 7c39ae0 to aa74baa Compare May 12, 2025 11:14
@simonrw simonrw marked this pull request as ready for review May 12, 2025 11:14
@simonrw simonrw requested a review from MEPalma May 12, 2025 11:14
pinzon
pinzon reviewed May 12, 2025
View reviewed changes
Copy link
Member
@pinzon pinzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@simonrw simonrw merged commit 0921a73 into master May 12, 2025
32 checks passed
@simonrw simonrw deleted the cfn/v2/deploy-error-handling branch May 12, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinzon pinzon pinzon left review comments

@MEPalma MEPalma MEPalma approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

Assignees
No one assigned
Labels
aws:cloudformation AWS CloudFormation semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simonrw @pinzon @MEPalma
0