CFn v2: better handle deploy errors #12601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalStack Community integration with Pro 2 files ± 0 2 suites ±0 21m 8s ⏱️ - 1h 21m 53s Results for commit aa74baa. ± Comparison against base commit e7383de. This pull request removes 3935 tests.♻️ This comment has been updated with latest results. |
7c39ae0 to
aa74baa
Compare
MEPalma
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently when a deploy error occurs, the stack does not get put into an error state, so the deploy process loops until it times out. If an exception occurs during the deploy process we should stop the deployment ASAP and mark it as failed so that our development and investigation can continue quicker, and this better reflects AWS state.
Changes
Catch an exception from the deploy process and mark the stack as failed.
Testing
Uncomment a skipped test from the
tests/aws/services/cloudformation/v2directory that fails during deployment time, and marvel at how quickly an error is thrown, whereas before it would take the wait time of the stack deployment to fail.