CloudFormation: Fix LoggingConfiguration Parameter Handling in StepFunctions Resource Provider #12433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe4dev
approved these changes
Mar 26, 2025
| sfn_snapshot.add_transformers_list( | ||
| [ | ||
| JsonpathTransformer("$..roleArn", "role-arn"), | ||
| JsonpathTransformer("$..stateMachineArn", "state-machine-arn"), |
There was a problem hiding this comment.
💡 It might be worth adding such transformers to the default StepFunctions service transformers in the future for the ones appearing frequently
| stack = deploy_cfn_template( | ||
| template_path=os.path.join( | ||
| os.path.dirname(__file__), | ||
| "../../../templates/statemachine_machine_logging_configuration.yml", |
There was a problem hiding this comment.
style nit: having a path helper or variable could simplify these error-prone ../../.... path navigations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR fixes a limitation in the CloudFormation resource provider for AWS Step Functions where the LoggingConfiguration parameters are not passed through during Create and Delete actions #11374. These changes address such limitation and add a related positive snapshot test.